Integrate Jagged PCS into CPU prover flow#1336
Open
hero78119 wants to merge 18 commits into
Open
Conversation
440b684 to
a8ab6e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Integrate Jagged PCS into the Ceno prover flow so trace commitments/openings can use Jagged over the existing Basefold PCS.
Design Rationale
Jagged PCS packs per-chip trace polynomials into q' and reduces batched openings before delegating the final PCS opening to Basefold. The verifier behavior is kept unchanged; prover-side q' opening now reuses inner PCS column MLEs instead of rebuilding a second flat q' buffer.
Change Highlights
ceno_zkvm: wire Jagged PCS into the CPU proving flow.mpcs: implement Jagged PCS trait integration and q' indexed view for opening.mpcs: document Basefold prover param sizing and q' layout assumptions.Benchmark / Performance Impact
CPU shard0 benchmark is close to baseline.
GPU
Block:
23817600, GPU,CENO_GPU_CACHE_LEVEL=1, reshape height:24commit_tracesextract_witness_mlesbuild_tower_witness_gpuprove_tower_relation_gpuprove_batched_main_constraintspcs_openingShard count:
15 -> 14(-1shard) on block23817600.Source runs:
Testing
cargo test -p mpcs jagged -- --nocapture cargo run --config net.git-fetch-with-cli=true --release --package ceno_zkvm --bin e2e -- \ --platform=ceno --max-cycle-per-shard=1600 \ examples/target/riscv32im-ceno-zkvm-elf/release/examples/keccak_syscallCopilot Reviewer Directive (keep this section)
When Copilot reviews this PR, apply
.github/copilot-instructions.mdstrictly.