feat: Conjugate app download data UI (SwiftUI)#651
Open
prince-0408 wants to merge 2 commits intoscribe-org:mainfrom
Open
feat: Conjugate app download data UI (SwiftUI)#651prince-0408 wants to merge 2 commits intoscribe-org:mainfrom
prince-0408 wants to merge 2 commits intoscribe-org:mainfrom
Conversation
- Add ConjugateDownloadDataScreen with SwiftUI - Shows all supported languages listed alphabetically (not just installed keyboards) - Update data card with check-for-new-data spinner and regularly-update toggle - Per-language download buttons with ready/downloading/updated/update states - Update all shortcut, toast feedback - Wire ConjugateTab card to navigate to download screen - Add i18n key for already-up-to-date toast message - Download functionality stubbed, to be implemented in follow-up issue Closes scribe-org#612
Thank you for the pull request! 💙🩵The Scribe-iOS team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #612
Changes
DownloadDataScreen.swiftConjugateTab.swiftLocalizable.xcstringsi18n.conjugate.download.already_up_to_datestring keyproject.pbxprojDownloadDataScreen.swiftin the Conjugate targetDownloadDataScreen.swift— DetailScreenshots
Notes