Fix OpenGraph extractor to find meta tags placed outside <head>#245
Open
danishashko wants to merge 1 commit intoscrapinghub:masterfrom
Open
Fix OpenGraph extractor to find meta tags placed outside <head>#245danishashko wants to merge 1 commit intoscrapinghub:masterfrom
danishashko wants to merge 1 commit intoscrapinghub:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extractor only searches
head.xpath("meta[@property and @content]"), which misses OG meta tags placed outside<head>. Some CMSs and page builders put OG tags in<body>, and those tags are currently silently ignored.Changing to
document.xpath(".//meta[@property and @content]")searches the whole document for OG meta tags with no change to the namespace detection logic.