Add 'w' as an English abbreviation for 'week' (#1257)#1349
Open
apoorvdarshan wants to merge 1 commit into
Open
Add 'w' as an English abbreviation for 'week' (#1257)#1349apoorvdarshan wants to merge 1 commit into
apoorvdarshan wants to merge 1 commit into
Conversation
'1w ago' returned None while '1d', '1h', '1m', '1s' and '1y' all worked:
every relative-time unit had a single-letter abbreviation except week.
Add 'w' to the English 'week' translation data and regenerate en.py.
'month' intentionally keeps no single-letter form ('m' is minute), but
'w' is unambiguous. Adds freshness parser tests for '1w ago'/'2w ago'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1257.
Problem
"1w ago"returnsNone, even though the full word and every other single-letter unit abbreviation work:Every relative-time unit had a single-letter abbreviation except week: in the English translation data,
dayhasd,hourhash,minutehasm,secondhass,yearhasy, butweekonly hadweek/wk/weeks.Fix
Add
wto the Englishweektranslation data indateparser_data/supplementary_language_data/date_translation_data/en.yamland regeneratedateparser/data/date_translation_data/en.pywithdateparser_scripts/write_complete_data.py.monthintentionally keeps no single-letter form (sincemalready means minute), butwis unambiguous, so this fills a genuine gap rather than introducing a conflict.Testing
"1w ago"/"2w ago"cases totests/test_freshness_date_parser.py(next to the existing"2y ago"abbreviation case). They fail onmainand pass with this change.tests/test_freshness_date_parser.py(1057) andtests/test_search.py(244) pass — no regressions.ruff check/ruff format --checkclean on the changed files.Disclosure: this change was prepared with the assistance of an AI tool (Claude Code). I reproduced the issue, made the data change and regenerated
en.pywith the project's own script, verified the fix and the test run, and take responsibility for the contribution and will respond to review feedback personally.