Draft
Conversation
This is an interim change as we may end up revamping pre-commit checks further, but in the meantime, might just as well reap benefits of prek over pre-commit. To migrate existing pre-commit enabled setups: prek install --overwrite --hook-type pre-commit --hook-type commit-msg
Owner
Author
|
Hm prek does not implement perl checks yet, so drafting. Deferring to docker based checks is an option (maybe better to require docker than perl these days 🤔). But even that is not quite there yet. For perltidy a docker image was recently added: https://github.com/perltidy/perltidy/pkgs/container/perltidy For perlcritic, it's (still) in progress: Perl-Critic/Perl-Critic#999 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an interim change as we may end up revamping pre-commit checks further, but in the meantime, might just as well reap benefits of prek over pre-commit.
To migrate existing pre-commit enabled setups:
prek install --overwrite --hook-type pre-commit --hook-type commit-msg