Skip to content

ci: check generated templates with development repo-review - #856

Merged
henryiii merged 1 commit into
scientific-python:mainfrom
psgundla:fix/template-repo-review-721
Sep 6, 2026
Merged

ci: check generated templates with development repo-review#856
henryiii merged 1 commit into
scientific-python:mainfrom
psgundla:fix/template-repo-review-721

Conversation

@psgundla

@psgundla psgundla commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

The generated-template lint session currently runs prek without checking the output against sp-repo-review. Install the development package from this checkout and run sp-repo-review . inside each generated project, so review failures fail the existing CI lint job.

Fixes #721.

Validation on macOS with Python 3.12:

  • uvx nox -s rr_lint passed.
  • uvx nox -s lint passed all 60 combinations: 10 backends, VCS enabled/disabled, and three documentation engines.
  • git diff --check passed.

📚 Documentation preview 📚: https://scientific-python-cookie--856.org.readthedocs.build/

@henryiii
henryiii merged commit 1f1a575 into scientific-python:main Sep 6, 2026
35 checks passed
@henryiii

henryiii commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: add check for sp-repo-review on the template output

2 participants