Skip to content

Handle deleted GH user #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jarrodmillman wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −6
Open

Handle deleted GH user #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/changelist/_objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from datetime import datetime
from typing import Optional, Union

from github import GithubException
from github.NamedUser import NamedUser
from github.PullRequest import PullRequest

Expand Down Expand Up @@ -126,11 +127,16 @@ def from_named_users(cls, named_users: set[NamedUser]) -> "set[Contributor]":
""" """
contributors = set()
for user in named_users:
contributors.add(
cls(
name=user.name,
login=user.login,
reference_url=user.html_url,
try:
contributors.add(
cls(
name=user.name,
login=user.login,
reference_url=user.html_url,
)
)
)
except GithubException as e:
# Safely fallback to the login handle if the object is missing (404)
print(f"\n[Warning] Skipped missing or deleted user: {getattr(user, 'login', 'Unknown')}")
continue
return contributors
Loading