Repository navigation
Fix Windows Needs-you toolbar UIA publication - #1013
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Windows Needs-you toolbar chip so its UI Automation provider publishes the exact public identity already emitted by
App.zig.Changes
header-attention:needs-youas the chip's static UIA AutomationId.Test plan
RED: pwsh -NoProfile -File Tools\windows\Tests\AccessibilityProvider.Native.Tests.ps1 -> 281 checks, 1 failure because the exact Needs-you AutomationId was missing
GREEN: pwsh -NoProfile -File Tools\windows\Tests\AccessibilityProvider.Native.Tests.ps1 -> 281 checks, 0 failures
REGRESSION: Tools\windows\Tests\AccessibilityProvider.Native.Tests.Harness.Tests.ps1 -PlanOnly -> 16 checks, 0 failures; focused classifier 3 checks, 0 failures; ValidationRunner filtered executed=9
Candidate and evidence identity
coneilen-needs-you-toolbar-cleanD97462A960C3C87A8173C7E24DFD632929871E05DC1BEC676AB51F59EFB87C47; original frozen receipt SHA2560D23F8816B72F02EA8DF30ACD38DA9D08EB127F877134EDAA74A05BCB56B147DStopping handoff
D:\gc-needs-you-tools\native-uia-final.log;D:\gc-needs-you-tools\native-plan-final.log;D:\gc-needs-you-tools\dialog-sheet-final.logNeeds-you destination did not preserve the Loops fragmentis explicitly excluded from this publication fixmainonlyChecklist
git commit -s) per the DCOmake test)make check)