Repository navigation
Verify Delete Loop modal identity - #1012
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Delete Loop UIA qualification so a closed or cancelled popup cannot be reported as command 5103, and bind the observed custom sheet to the exact modal handle returned by popup input.
Changes
Test plan
RED: pwsh -NoProfile -Command ". .\Tools\windows\Import-PinnedPester.ps1; Invoke-Pester -Path .\Tools\windows\Tests\CanvasCardContextMenu.Tests.ps1 -Output Detailed -CI" -> 16 passed, 1 failed because the modal-completion contract was absent
GREEN: pwsh -NoProfile -Command ". .\Tools\windows\Import-PinnedPester.ps1; Invoke-Pester -Path .\Tools\windows\Tests\CanvasCardContextMenu.Tests.ps1 -Output Detailed -CI" -> 17 passed, 0 failed
REGRESSION: pwsh -NoProfile -File .\Tools\windows\ValidationRunner\Ui\UiDerivedContracts.ps1 -RepositoryRoot D:\depot\copilot-worktrees\GraphCode\coneilen-bookish-chainsaw -ArtifactRoot C:\gc-delete-loop-artifacts\ui-derived -AssemblyPath D:\depot\copilot-worktrees\GraphCode\coneilen-bookish-chainsaw\Tools\windows\ValidationRunner\bin\Release\net10.0-windows\ValidationRunner.dll -> 27 passed, 0 failed
Tier C live UIA:
pwsh -NoProfile -File .\Tools\windows\uia-live-gate.ps1 -Shell D:\depot\copilot-worktrees\GraphCode\coneilen-effective-meme\graphcode-windows\zig-out\bin\graphcode-windows.exe -Zmx C:\gc-q721\providers\zmx\zig-out\bin\zmx.exe -SidebarParityOnlyexited 0. The popup receipt and reacquiredDelete “UIA loop A”?sheet both had native handle 53216670, and owned-process cleanup passed. A prior admitted retry first exposed the existing popup-cancellation flake; its cleanup was verified and the successful retry is retained separately.Full
Tools\windows\Tests\ValidationRunner.Tests.ps1remains blocked by the unrelated pre-existing line-3718 process-reaping assertion before this section. This PR does not claim a full ValidationRunner pass.Candidate and evidence identity
Stopping handoff
delete-loop-identity-focused.log; deriveddelete-loop-identity-derived.log; livedelete-loop-identity-live-retry.log; original Windows parity: Window toolbar needs live Needs-you chip, notice boundary and rendered comparison (testing gap) #721 receipt retained separatelyChecklist
git commit -s) per the DCOmake test)make check)