Skip to content

Verify Delete Loop modal identity - #1012

Merged
coneilen merged 1 commit into
mainfrom
coneilen-delete-loop-sheet-defect
Nov 13, 2026
Merged

coneilen merged 1 commit into
mainfrom
coneilen-delete-loop-sheet-defect

Conversation

@coneilen

Copy link
Copy Markdown
Collaborator

Summary

Fix the Delete Loop UIA qualification so a closed or cancelled popup cannot be reported as command 5103, and bind the observed custom sheet to the exact modal handle returned by popup input.

Changes

  • Use the modal-aware popup action for Delete Loop.
  • Require the reacquired custom sheet handle to match the popup modal completion handle.
  • Add focused source and mutation coverage for popup completion and exact sheet identity.

Test plan

RED: pwsh -NoProfile -Command ". .\Tools\windows\Import-PinnedPester.ps1; Invoke-Pester -Path .\Tools\windows\Tests\CanvasCardContextMenu.Tests.ps1 -Output Detailed -CI" -> 16 passed, 1 failed because the modal-completion contract was absent
GREEN: pwsh -NoProfile -Command ". .\Tools\windows\Import-PinnedPester.ps1; Invoke-Pester -Path .\Tools\windows\Tests\CanvasCardContextMenu.Tests.ps1 -Output Detailed -CI" -> 17 passed, 0 failed
REGRESSION: pwsh -NoProfile -File .\Tools\windows\ValidationRunner\Ui\UiDerivedContracts.ps1 -RepositoryRoot D:\depot\copilot-worktrees\GraphCode\coneilen-bookish-chainsaw -ArtifactRoot C:\gc-delete-loop-artifacts\ui-derived -AssemblyPath D:\depot\copilot-worktrees\GraphCode\coneilen-bookish-chainsaw\Tools\windows\ValidationRunner\bin\Release\net10.0-windows\ValidationRunner.dll -> 27 passed, 0 failed

Tier C live UIA: pwsh -NoProfile -File .\Tools\windows\uia-live-gate.ps1 -Shell D:\depot\copilot-worktrees\GraphCode\coneilen-effective-meme\graphcode-windows\zig-out\bin\graphcode-windows.exe -Zmx C:\gc-q721\providers\zmx\zig-out\bin\zmx.exe -SidebarParityOnly exited 0. The popup receipt and reacquired Delete “UIA loop A”? sheet both had native handle 53216670, and owned-process cleanup passed. A prior admitted retry first exposed the existing popup-cancellation flake; its cleanup was verified and the successful retry is retained separately.

Full Tools\windows\Tests\ValidationRunner.Tests.ps1 remains blocked by the unrelated pre-existing line-3718 process-reaping assertion before this section. This PR does not claim a full ValidationRunner pass.

Candidate and evidence identity

  • Tier(s): Tier A, Tier C
  • Branch: coneilen-delete-loop-sheet-defect
  • HEAD / tree: 9d9375a / 61cbd793c852e9a9121e46c2c5a6940b85fdffd9 (dirty)
  • Candidate hashes: shell 7B3107CEB6D9F8FEE77A29E0F7595A32476A02A7BF49FB6AAA098F9C59752538; zmx EE44826BFF28F0F7A2FF735558481BF4917F0FDBA6D403B67CE0554E8D3B49DE; gate 6D137916F78F85850451DA540215B3DAC2834657DB54F61755A64311792BBCE9

Stopping handoff

  • Next exact command: required exact-head PR workflows will run after publication
  • Positive count: 17 focused tests, 27 derived contracts, 1 successful live UIA lane
  • Permissions / time / desktop: approved publication; live Windows desktop execution completed with owned cleanup
  • Blocker category: test/harness
  • Evidence paths: focused delete-loop-identity-focused.log; derived delete-loop-identity-derived.log; live delete-loop-identity-live-retry.log; original Windows parity: Window toolbar needs live Needs-you chip, notice boundary and rendered comparison (testing gap) #721 receipt retained separately
  • Stopping condition: PR publication only; no merge or unrelated line-3718 scope work
  • Publication authority: user approved push and pull request creation only

Checklist

  • I have read the Contributing Guidelines
  • I have signed off my commits (git commit -s) per the DCO
  • Tests pass locally (make test)
  • Code follows the existing style (make check)
  • I added the test/contract before the implementation and observed the intended RED failure
  • The evidence tier is explicit and the frozen candidate tuple matches the cited evidence
  • Any failure was classified and preserved before correction or retry

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
@coneilen
coneilen merged commit 16a787a into main Nov 13, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant