Chore/sp 4330 replace error status by info status#37
Conversation
📝 WalkthroughWalkthroughThe pull request updates project dependencies to newer versions, documents a version 0.9.0 release with a breaking change, and modifies the component status API response to replace Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
isasmendiagus
left a comment
There was a problem hiding this comment.
LGTM, see small comment on CHANGELOG.md
…sage/info_code in component status responses
a6926ba to
a3b6913
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pkg/service/component_support.go`:
- Around line 189-194: The version-error branch is incorrectly reading from
output.ComponentStatus instead of output.VersionStatus which can be nil or
wrong; modify the block where msg, code and response.VersionStatus are set
(currently using output.ComponentStatus.ErrorMessage/ErrorCode and creating
pb.ComponentStatusResponse_VersionStatus) to use
output.VersionStatus.ErrorMessage and output.VersionStatus.ErrorCode (convert
ErrorCode to string only if non-nil) and assign those to InfoMessage and
InfoCode, guarding against nil ErrorCode so you don’t dereference a nil pointer.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 409852b2-bbc0-46bc-94f4-948960191da0
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (4)
.gitignoreCHANGELOG.mdgo.modpkg/service/component_support.go
API
components/status/componentsresponseThrough scanoss.py CLI
Summary by CodeRabbit
Breaking Changes
InfoMessageandInfoCodefields instead ofErrorMessageandErrorCodefor component and version status reporting.Chores