✨ S3UTILS-230 implement CRR multi-site V2 replication format#396
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development/1 #396 +/- ##
=================================================
+ Coverage 44.90% 45.31% +0.41%
=================================================
Files 88 88
Lines 6456 6516 +60
Branches 1352 1369 +17
=================================================
+ Hits 2899 2953 +54
- Misses 3511 3513 +2
- Partials 46 50 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d5490b8 to
f9fca0c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
maeldonn
left a comment
There was a problem hiding this comment.
Can be simplified a lot by using arsenal logic
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following reviewers are expecting changes from the author, or must review again: |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
d1e9317 to
dcbdaa0
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following reviewers are expecting changes from the author, or must review again: |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
Sorry for the delay :) Good work |
006d95a to
6ad3454
Compare
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
This pull request does not target the following hotfix branch(es) so they
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue S3UTILS-230. Goodbye darkisdude. |
Summary
Changes
`CRR/ReplicationStatusUpdater.js`
`package.json` — arsenal pinned to `improvement/ARSN-571/crr-multi` for the new static methods
`tests/utils/crr.js` — V2 bucket replication config fixture
`tests/unit/CRR/ReplicationStatusUpdater.js` — 7 new V2 test cases (single match, dual-rule prefix overlap, no-match skip, SITE_NAME filter, all-up-to-date skip, PROCESSING aggregate status, forceUsingConfiguration)
Test plan
Issue: S3UTILS-230
:80. Should we ping CS or update the page directly ?