Repository navigation
test: go-generated push on a Renovate branch, do not merge (MK8S-516) - #93
Closed
ezekiel-alexrod wants to merge 3 commits into
Closed
ezekiel-alexrod wants to merge 3 commits into
ezekiel-alexrod wants to merge 3 commits into
Conversation
On a Renovate branch it also pushes the regenerated mocks, so a mockery bump no longer needs a human commit. Refs: MK8S-516
| secrets: | ||
| ACTIONS_APP_PRIVATE_KEY: ${{ secrets.ACTIONS_APP_PRIVATE_KEY }} | ||
| with: | ||
| push-to-renovate-branches: true |
There was a problem hiding this comment.
With push mode on, the App's chore(deps): regenerate the code commit lands on the Renovate branch. Unless the App's bot email is in Renovate's gitIgnoredAuthors, Renovate treats the branch as edited by someone else and stops rebasing or updating it. The reusable workflow's step summary also says to add it. .github/renovate.json only extends github>scality/platform-renovate, and I couldn't read that preset to check. If the preset doesn't set it, add gitIgnoredAuthors here (or in #92).
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway PR, do not merge. It tests the push mode of
go-generatedbefore the adoption in #92.The branch name starts with
renovate/, and its last commit drops a line ofpkg/service/mocks.go. Expected: the first run fails on the stale mock and pushes a commit from the App that restores it, then the next run passes.I'll close it and delete the branch once checked.
Refs: MK8S-516