Skip to content

test: go-generated push on a Renovate branch, do not merge (MK8S-516) - #93

Closed
ezekiel-alexrod wants to merge 3 commits into
mainfrom
renovate/test-go-generated
Closed

ezekiel-alexrod wants to merge 3 commits into
mainfrom
renovate/test-go-generated

Conversation

@ezekiel-alexrod

Copy link
Copy Markdown
Contributor

Throwaway PR, do not merge. It tests the push mode of go-generated before the adoption in #92.

The branch name starts with renovate/, and its last commit drops a line of pkg/service/mocks.go. Expected: the first run fails on the stale mock and pushes a commit from the App that restores it, then the next run passes.

I'll close it and delete the branch once checked.


Refs: MK8S-516

On a Renovate branch it also pushes the regenerated mocks, so a mockery
bump no longer needs a human commit.

Refs: MK8S-516
secrets:
ACTIONS_APP_PRIVATE_KEY: ${{ secrets.ACTIONS_APP_PRIVATE_KEY }}
with:
push-to-renovate-branches: true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With push mode on, the App's chore(deps): regenerate the code commit lands on the Renovate branch. Unless the App's bot email is in Renovate's gitIgnoredAuthors, Renovate treats the branch as edited by someone else and stops rebasing or updating it. The reusable workflow's step summary also says to add it. .github/renovate.json only extends github>scality/platform-renovate, and I couldn't read that preset to check. If the preset doesn't set it, add gitIgnoredAuthors here (or in #92).

@ezekiel-alexrod

Copy link
Copy Markdown
Contributor Author

Test done: the App pushed 754cf6e and the next run passed. Results in #92.

@ezekiel-alexrod
ezekiel-alexrod deleted the renovate/test-go-generated branch November 19, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant