Repository navigation
Conversation
So that other unit tests can put a replication configuration on a bucket. Issue: CLDSRV-1085
The createAndStoreObject call creating the delete marker was missing the overheadField argument, shifting log, originOp and the callback. The first log call then threw an uncaught TypeError, crashing the worker. The argument was added by CLDSRV-449 on a branch without this NFS code path, and the call site was missed when merging forward. Issue: CLDSRV-1085
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
| next => objectDelete(authInfo, testDeleteRequest, log, next), | ||
| next => | ||
| objectGet(authInfo, testGetObjectRequest, false, log, err => { | ||
| assert.strictEqual(err.is.NoSuchKey, true); |
There was a problem hiding this comment.
Compare the error message instead of err.is.NoSuchKey, so a failure shows the actual error. If the object was not deleted, err is null and err.is throws a TypeError instead of a clear assertion failure.
| assert.strictEqual(err.is.NoSuchKey, true); | |
| assert.strictEqual(err?.message, 'NoSuchKey'); |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 2 files with indirect coverage changes @@ Coverage Diff @@
## development/9.6 #6389 +/- ##
===================================================
+ Coverage 90.86% 90.89% +0.03%
===================================================
Files 208 208
Lines 39275 39276 +1
===================================================
+ Hits 35686 35701 +15
+ Misses 3589 3575 -14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
On an NFS bucket with replication, DeleteObject called
createAndStoreObjectwithout theoverheadFieldargument. The remaining arguments shifted, sologreceived the originOp string and the firstlog.tracethrew an uncaughtTypeError, crashing the worker.The argument was added by CLDSRV-449 on a branch without this NFS code path, and this call site was missed when merging forward.
bucketPutVersioningtests intotests/unit/helpers.js(no behaviour change).overheadField, with a unit test deleting an object in an NFS bucket with replication.Issue: CLDSRV-1085