Repository navigation
CLDSRV-1008 return object lock state even if bucket is not lock-enabled - #6386
Open
francoisferrand wants to merge 1 commit into
Open
francoisferrand wants to merge 1 commit into
francoisferrand wants to merge 1 commit into
Conversation
Contributor
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## development/9.6 #6386 +/- ##
================================================
Coverage 90.86% 90.86%
================================================
Files 208 208
Lines 39275 39278 +3
================================================
+ Hits 35686 35689 +3
Misses 3589 3589
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
GetObjectRetention and GetObjectLegalHold errored out whenever the bucket was not lock-enabled, even when the object actually carried lock information, while GET/HEAD already exposed it through the x-amz-object-lock-* headers. On a DR site, the replicated lock state is enforced from object metadata while the bucket is deliberately not lock-enabled, and backup clients still need to read it. So return whatever is set on the object; when nothing is set, keep the existing errors. Issue: CLDSRV-1008
francoisferrand
force-pushed
the
improvement/CLDSRV-1008
branch
from
November 20, 2026 10:58
d7dafa0 to
005068e
Compare
DarkIsDude
approved these changes
Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetObjectRetention and GetObjectLegalHold used to fail as soon as the bucket was not lock-enabled, even if the object actually had lock information. Meanwhile GET/HEAD already return it through the
x-amz-object-lock-*headers, so the two views disagreed.This matters on DR sites: the replicated lock state is enforced from object metadata, but the DR bucket is deliberately not lock-enabled, and backup clients still need to read that state.
So now, whatever is set on the object gets returned: its retention, or its legal hold (ON or OFF). When nothing is set, the existing
InvalidRequeston a non-lock bucket is unchanged.Issue: CLDSRV-1008