Skip to content

CLDSRV-977: add storeCompositeChecksums feature flag - #6257

Merged
bert-e merged 1 commit into
development/9.4from
improvement/CLDSRV-977-composite-feature-flag
Aug 19, 2026
Merged

CLDSRV-977: add storeCompositeChecksums feature flag#6257
bert-e merged 1 commit into
development/9.4from
improvement/CLDSRV-977-composite-feature-flag

Conversation

@leif-scality

@leif-scality leif-scality commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Add storeCompositeChecksums feature flag
  • Will be used in the future PR's for storing COMPOSITE checksums
  • parseIntegrityChecks now uses Joi

@bert-e

bert-e commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Hello leif-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-977 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.4.2

Please check the Fix Version/s of CLDSRV-977, or the target
branch of this pull request.

@codecov

codecov Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

❌ 9 Tests Failed:

Tests completed Failed Passed Skipped
9878 9 9869 0
View the top 2 failed test(s) by shortest run time 
should retrieve a part copied from an MPU after the original part was overwritten::GET object With default signature With PartNumber field uploadPartCopy overwrite should retrieve a part copied from an MPU after the original part was overwritten
Stack Traces | 40s run time 
Timeout of 40000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (.../test/object/get.js)
should create an encrypted bucket and upload an object::KMIP backed server-side encryption should create an encrypted bucket and upload an object
Stack Traces | 40s run time 
Timeout of 40000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (.../functional/kmip/serverside_encryption.js)
View the full list of 9 ❄️ flaky test(s) 
"before each" hook for "should grant read access"::With default signature PUT Bucket ACL using predefined groups - authenticated request "before each" hook for "should grant read access"

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.389s run time 
We encountered an internal error. Please try again.
"before each" hook for "should grant read access"::With default signature PUT Bucket ACL using predefined groups - unauthenticated request "before each" hook for "should grant read access"

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.041s run time 
We encountered an internal error. Please try again.
"before each" hook for "should grant read access"::With default signature PUT Object ACL using predefined groups - authenticated request "before each" hook for "should grant read access"

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.181s run time 
We encountered an internal error. Please try again.
"before each" hook for "should grant read access"::With default signature PUT Object ACL using predefined groups - unauthenticated request "before each" hook for "should grant read access"

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.126s run time 
We encountered an internal error. Please try again.
"before each" hook for "should grant read access"::With v4 signature PUT Bucket ACL using predefined groups - authenticated request "before each" hook for "should grant read access"

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.055s run time 
We encountered an internal error. Please try again.
"before each" hook for "should grant read access"::With v4 signature PUT Bucket ACL using predefined groups - unauthenticated request "before each" hook for "should grant read access"

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.048s run time 
We encountered an internal error. Please try again.
"before each" hook for "should grant read access"::With v4 signature PUT Object ACL using predefined groups - authenticated request "before each" hook for "should grant read access"

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.046s run time 
We encountered an internal error. Please try again.
"before each" hook for "should grant read access"::With v4 signature PUT Object ACL using predefined groups - unauthenticated request "before each" hook for "should grant read access"

Flake rate in main: 100.00% (Passed 0 times, Failed 20 times)

Stack Traces | 0.042s run time 
We encountered an internal error. Please try again.
should allow action on an object specified in the policy::With default signature Bucket policies with resource statement should allow action on an object specified in the policy

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 40s run time 
Timeout of 40000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (.../test/bucket/bucketPolicyWithResourceStatements.js)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@bert-e

bert-e commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@leif-scality

leif-scality commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

ping

@leif-scality

leif-scality commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.4

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1
  • development/9.2
  • development/9.3

This pull request did not target the following hotfix branch(es) so they
were left untouched:

  • hotfix/7.4.0
  • hotfix/7.10.3
  • hotfix/7.8.0
  • hotfix/7.70.21
  • hotfix/7.70.73
  • hotfix/7.10.0
  • hotfix/7.4.9
  • hotfix/7.10.4
  • hotfix/7.10.1
  • hotfix/7.4.5
  • hotfix/7.9.0
  • hotfix/7.4.8
  • hotfix/8.8.45
  • hotfix/7.10.27
  • hotfix/7.10.30
  • hotfix/7.10.49
  • hotfix/7.10.15
  • hotfix/7.6.0
  • hotfix/9.0.7
  • hotfix/7.2.0
  • hotfix/7.4.10
  • hotfix/7.7.0
  • hotfix/7.70.45
  • hotfix/6.4.7
  • hotfix/7.4.1
  • hotfix/7.4.4
  • hotfix/7.70.11
  • hotfix/9.2.36
  • hotfix/7.10.28
  • hotfix/7.4.3
  • hotfix/7.4.6
  • hotfix/9.0.32
  • hotfix/7.10.8
  • hotfix/7.10.2
  • hotfix/7.70.51
  • hotfix/7.4.7
  • hotfix/7.4.2
  • hotfix/9.2.24

Please check the status of the associated issue CLDSRV-977.

Goodbye leif-scality.

The following options are set: approve

@bert-e
bert-e merged commit cc1cd63 into development/9.4 Aug 19, 2026
62 of 63 checks passed
@bert-e
bert-e deleted the improvement/CLDSRV-977-composite-feature-flag branch August 19, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anurag4DSB anurag4DSB anurag4DSB approved these changes
@SylvainSenechal SylvainSenechal SylvainSenechal approved these changes
@BourgoisMickael BourgoisMickael BourgoisMickael approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@leif-scality @bert-e @anurag4DSB @SylvainSenechal @BourgoisMickael