CLDSRV-881: fix missing CORS headers on 403 responses

[tcarmet]

Fixes CLDSRV-881: Access-Control-* headers were missing from 403 responses when a bucket has CORS configured.

[bert-e]

Hello tcarmet,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue CLDSRV-881 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.2.33

• 9.3.6

• 9.4.0

Please check the Fix Version/s of CLDSRV-881, or the target
branch of this pull request.

[claude]

LGTM

The fix is correct: standardMetadataValidateBucketAndObj intentionally returns bucket on error (line 427 of metadataUtils.js: "still return bucket for cors headers"), but updateEncryption was dropping it by calling cb(err) without forwarding the bucket. This caused collectCorsHeaders to receive undefined and return empty headers on 403 responses. The tests cover the right cases (specific origin, wildcard, and no-origin).

Review by Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.17%. Comparing base (a4314a8) to head (d7eec24).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/api/apiUtils/bucket/updateEncryption.js	17.85% <100.00%> (ø)

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.2    #6126      +/-   ##
===================================================
- Coverage            84.18%   84.17%   -0.02%     
===================================================
  Files                  204      204              
  Lines                13124    13124              
===================================================
- Hits                 11049    11047       -2     
- Misses                2075     2077       +2     

Flag	Coverage Δ
file-ft-tests	67.61% <100.00%> (ø)
kmip-ft-tests	28.19% <0.00%> (ø)
mongo-v0-ft-tests	68.85% <100.00%> (-0.03%)	⬇️
mongo-v1-ft-tests	68.85% <100.00%> (ø)
multiple-backend	35.24% <0.00%> (ø)
sur-tests	35.75% <100.00%> (-0.84%)	⬇️
sur-tests-inflights	37.60% <100.00%> (-0.04%)	⬇️
utapi-v2-tests	34.50% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.