Skip to content

Improvement/cldsrv 875 integrate shared prettier #6124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benzekrimaha wants to merge 9 commits into
base: development/9.3
Choose a base branch
from
+934 −825
Open

Improvement/cldsrv 875 integrate shared prettier #6124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b6bd810
add shared prettier baseline
benzekrimaha Apr 2, 2026
8dacb04
add ci prettier changed-file check
benzekrimaha Apr 2, 2026
ed72659
update doc for package.json linting
benzekrimaha Apr 2, 2026
568360a
format test.yaml file to meet prettier requirements
benzekrimaha Apr 2, 2026
902ab8b
ignore generated files
benzekrimaha Apr 2, 2026
49bb1b5
fixup! add ci prettier changed-file check
benzekrimaha Apr 2, 2026
2699e18
fixup! update doc for package.json linting
benzekrimaha Apr 2, 2026
4812867
fixup! update doc for package.json linting
benzekrimaha Apr 2, 2026
47fedf5
fixup! add ci prettier changed-file check
benzekrimaha Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
---
name: lint

on:
pull_request:

permissions:
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.ref_name || github.sha }}
Copy link
Copy Markdown
Contributor

@francoisferrand francoisferrand Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.head_ref and github.ref_name are always set for pull_request, no point making things more complicated

Suggested change
group: ${{ github.workflow }}-${{ github.head_ref || github.ref_name || github.sha }}
group: ${{ github.workflow }}-${{ github.head_ref }}

cancel-in-progress: true

jobs:
lint:
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
- uses: actions/setup-node@v4
Comment on lines +19 to +20
Copy link
Copy Markdown
Contributor

@francoisferrand francoisferrand Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are not the latest actions: upgrade instead of introducing old dependency

with:
node-version: '22'
cache: yarn
- name: install typescript
shell: bash
run: yarn global add typescript@4.9.5
- name: install dependencies
run: yarn install --frozen-lockfile --network-concurrency 1
- name: Fetch base for Prettier
env:
BASE_REF: ${{ github.event.pull_request.base.ref }}
run: git fetch --no-tags origin "$BASE_REF" --depth=50
- name: Prettier (changed files)
run: scripts/format-changed.sh
env:
BASE_SHA: ${{ github.event.pull_request.base.sha }}
BASE_REF: ${{ github.event.pull_request.base.ref }}
- uses: actions/setup-python@v5
with:
python-version: '3.9'
cache: pip
- name: Install python deps
run: pip install flake8
- name: Lint Javascript
run: yarn run --silent lint -- --max-warnings 0
- name: Lint Markdown
run: yarn run --silent lint_md
- name: Lint python
run: flake8 $(git ls-files "*.py")
- name: Lint Yaml
run: yamllint -c yamllint.yml $(git ls-files "*.yml")
Loading
Loading