👷(CLDSRV-860) Monitor async await migration by DarkIsDude · Pull Request #6088 · scality/cloudserver

DarkIsDude · 2026-02-25T15:47:58Z

https://scality.atlassian.net/wiki/spaces/OS/pages/3523346468/2025-10-30+-+Async+Await+migration

.github/scripts/check-diff-async.mjs

.github/workflows/tests.yaml

.github/scripts/count-async-functions.mjs

.github/scripts/check-diff-async.mjs

.github/workflows/tests.yaml

.github/scripts/count-async-functions.mjs

.github/workflows/tests.yaml

.github/scripts/check-diff-async.mjs

.github/scripts/count-async-functions.mjs

.github/scripts/check-diff-async.mjs

.github/scripts/count-async-functions.mjs

package.json

Issue: CLDSRV-860

claude · 2026-03-30T15:24:20Z

LGTM

Clean PR. The CodeQL queries, diff checker, and migration counter are well-structured. The eslint rule additions (promise/prefer-await-to-then, n/callback-return as warn) with CI overrides to keep the strict lint passing is a good incremental approach. Tests cover the key paths.

Review by Claude Code

.github/scripts/check-diff-async.mjs

package.json

.github/workflows/tests.yaml

.github/scripts/check-diff-async.mjs

.github/scripts/count-async-functions.mjs

Issue: CLDSRV-860

.github/scripts/check-diff-async.mjs

.github/scripts/count-async-functions.mjs

DarkIsDude self-assigned this Feb 25, 2026

This comment was marked as resolved.

Sign in to view

DarkIsDude changed the base branch from development/9.2 to development/9.3 February 25, 2026 15:48

This comment was marked as resolved.

Sign in to view

DarkIsDude commented Mar 10, 2026

View reviewed changes

.github/scripts/check-diff-async.mjs Outdated Show resolved Hide resolved

DarkIsDude marked this pull request as ready for review March 10, 2026 16:09

DarkIsDude requested review from a team, benzekrimaha and delthas March 10, 2026 16:09

DarkIsDude force-pushed the feature/CLDSRV-860/monitor-async-await-migration branch from 93020af to 8981239 Compare March 10, 2026 16:10

claude bot reviewed Mar 10, 2026

View reviewed changes

.github/scripts/check-diff-async.mjs Outdated Show resolved Hide resolved

claude bot reviewed Mar 10, 2026

View reviewed changes

.github/workflows/tests.yaml Outdated Show resolved Hide resolved

claude bot reviewed Mar 10, 2026

View reviewed changes

.github/scripts/count-async-functions.mjs Outdated Show resolved Hide resolved

claude bot reviewed Mar 10, 2026

View reviewed changes

.github/scripts/check-diff-async.mjs Outdated Show resolved Hide resolved

claude bot reviewed Mar 10, 2026

View reviewed changes

.github/workflows/tests.yaml Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

francoisferrand requested changes Mar 11, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

DarkIsDude force-pushed the feature/CLDSRV-860/monitor-async-await-migration branch from a64c535 to f1e7018 Compare March 19, 2026 13:23

claude bot reviewed Mar 19, 2026

View reviewed changes

.github/scripts/count-async-functions.mjs Outdated Show resolved Hide resolved

claude bot reviewed Mar 19, 2026

View reviewed changes

.github/scripts/count-async-functions.mjs Outdated Show resolved Hide resolved

claude bot reviewed Mar 19, 2026

View reviewed changes

.github/scripts/count-async-functions.mjs Show resolved Hide resolved

claude bot reviewed Mar 19, 2026

View reviewed changes

.github/scripts/check-diff-async.mjs Outdated Show resolved Hide resolved

claude bot reviewed Mar 19, 2026

View reviewed changes

.github/scripts/check-diff-async.mjs Outdated Show resolved Hide resolved

claude bot reviewed Mar 19, 2026

View reviewed changes

.github/scripts/count-async-functions.mjs Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

claude bot reviewed Mar 30, 2026

View reviewed changes

.github/scripts/count-async-functions.mjs Outdated Show resolved Hide resolved

claude bot reviewed Mar 30, 2026

View reviewed changes

package.json Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

DarkIsDude added 9 commits March 30, 2026 17:21

🚨 add eslint configuration to monitor async/await

9dff1c5

Issue: CLDSRV-860

👷 update CI to add new check on async/await file

afc3df1

Issue: CLDSRV-860

👷 remove then check from the code

5dcc3b4

Issue: CLDSRV-860

👷 remove async/await rule in the CI

fbdc6fd

Issue: CLDSRV-860

✨ add count array source path from package.json

715261b

Issue: CLDSRV-860

✅ create test for new scripts

71cdf6d

Issue: CLDSRV-860

🔒️ use array argument to avoid injection

3bf3610

Issue: CLDSRV-860

👷 change how we compute the migration progress

d6efbc3

Issue: CLDSRV-860

👷 init the CodeQL for async/await

a6705dd

Issue: CLDSRV-860

DarkIsDude force-pushed the feature/CLDSRV-860/monitor-async-await-migration branch from cb7c034 to a6705dd Compare March 30, 2026 15:21

claude bot reviewed Mar 31, 2026

View reviewed changes

.github/scripts/check-diff-async.mjs Show resolved Hide resolved

claude bot reviewed Mar 31, 2026

View reviewed changes

package.json Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

DarkIsDude force-pushed the feature/CLDSRV-860/monitor-async-await-migration branch from 3fe4eec to 13dcaeb Compare March 31, 2026 15:08

claude bot reviewed Mar 31, 2026

View reviewed changes

.github/workflows/tests.yaml Show resolved Hide resolved

claude bot reviewed Mar 31, 2026

View reviewed changes

.github/scripts/check-diff-async.mjs Show resolved Hide resolved

claude bot reviewed Mar 31, 2026

View reviewed changes

.github/scripts/count-async-functions.mjs Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

👷 restrict counter only on dev branch

2421cbf

Issue: CLDSRV-860

DarkIsDude force-pushed the feature/CLDSRV-860/monitor-async-await-migration branch from 13dcaeb to 2421cbf Compare March 31, 2026 15:13

claude bot reviewed Mar 31, 2026

View reviewed changes

.github/scripts/check-diff-async.mjs Show resolved Hide resolved

claude bot reviewed Mar 31, 2026

View reviewed changes

.github/scripts/count-async-functions.mjs Show resolved Hide resolved

claude bot reviewed Mar 31, 2026

View reviewed changes

.github/scripts/count-async-functions.mjs Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

DarkIsDude requested a review from francoisferrand March 31, 2026 17:42

francoisferrand approved these changes Apr 3, 2026

View reviewed changes

Conversation

DarkIsDude commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

This comment was marked as resolved.

claude bot commented Mar 30, 2026

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DarkIsDude commented Feb 25, 2026 •

edited

Loading