Repository navigation
Fix mutable default arguments, shared RetryTimeout instance and wrong UPDATE error message - #302
Closed
claude-agentic-bot[bot] wants to merge 1 commit into
Closed
claude-agentic-bot[bot] wants to merge 1 commit into
claude-agentic-bot[bot] wants to merge 1 commit into
Conversation
…ost/retry helpers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small robustness cleanups found while reviewing the repo:
git_host/base.py:get/list/create/updateused mutable defaults (params={},headers={}). Replaced withNoneand normalised inside the methods, so a mutation by a client can't leak between calls.git_host/base.py:update()raised'CREATE is not supported…'; it now saysUPDATE.lib/retry.py:RetryHandler.wait(err=RetryTimeout())created one exception instance at definition time, shared by every call (traceback accumulates on reuse). It now defaults toNoneand a freshRetryTimeoutis raised. Also removed an obsolete Python 2 comment.No behaviour change for callers passing explicit arguments.
Testing
Only
py_compilewas run: pytest/flake8 are not installed in my environment, so please rely on CI for the test suite.