Add Cucumber tests for multi-destination CRR#2451
Open
maeldonn wants to merge 1 commit into
Open
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
SylvainSenechal
left a comment
SylvainSenechal
left a comment
Contributor
There was a problem hiding this comment.
For me it's pretty much ok, I left some comment that you can check, I think it's ok if the suggested changes aren't applied but there may be some refactoring possible to make it a bit easier to read
maeldonn
force-pushed
the
improvement/ZENKO-5253/multi-crr
branch
from
831f001 to
6b088f0
Compare
Contributor
|
Can rebase on top of 2.16 (since #2378 was merged). Includes CRR changes. |
SylvainSenechal
force-pushed
the
improvement/ZENKO-5263
branch
2 times, most recently
from
a81cba1 to
d87c34e
Compare
Contributor
rebase from my branch, which i also just rebased from 2.16 |
Cover V2 multi-rule replication configs, mixed CRR + cloud destinations, overlap validation, disabled rules, and V1 plus legacy comma-StorageClass backward compatibility. Factor shared replication polling and replica-match helpers out of the existing single-destination steps so both single- and multi-destination scenarios reuse them. Issue: ZENKO-5253
maeldonn
force-pushed
the
improvement/ZENKO-5253/multi-crr
branch
from
6b088f0 to
0adb292
Compare
SylvainSenechal
approved these changes
Jul 2, 2026
SylvainSenechal
left a comment
SylvainSenechal
left a comment
Contributor
There was a problem hiding this comment.
Just nit on linter warning single line if and alignement of rules array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover V2 multi-rule replication configs, mixed CRR + cloud destinations, overlap validation, disabled rules, and V1 plus legacy comma-StorageClass backward compatibility. Factor shared replication polling and replica-match helpers out of the existing single-destination steps so both single- and multi-destination scenarios reuse them.
Issue: ZENKO-5253