Skip to content

feat(chart): let object-store workloads mount extra volumes #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
scalejeff wants to merge 1 commit into
base: main
Choose a base branch
from
+55 −1
Draft

feat(chart): let object-store workloads mount extra volumes #872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/model-engine/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.2.9
version: 0.2.10

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
45 changes: 45 additions & 0 deletions charts/model-engine/templates/service_template_config_map.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,9 @@ data:
memory: ${MEMORY}
${STORAGE_DICT}
volumeMounts:
{{- with $.Values.extraPodVolumeMounts }}
{{- toYaml . | nindent 16 }}
{{- end }}
{{- if $require_aws_config }}
- name: config-volume
mountPath: /opt/.aws/config
Expand All @@ -385,6 +388,9 @@ data:
securityContext:
fsGroup: 65534
volumes:
{{- with $.Values.extraPodVolumes }}
{{- toYaml . | nindent 12 }}
{{- end }}
{{- if $require_aws_config }}
- name: config-volume
configMap:
Expand Down Expand Up @@ -774,6 +780,9 @@ data:
memory: ${MEMORY}
${STORAGE_DICT}
volumeMounts:
{{- with $.Values.extraPodVolumeMounts }}
{{- toYaml . | nindent 18 }}
{{- end }}
{{- if $require_aws_config }}
- name: config-volume
mountPath: /opt/.aws/config
Expand All @@ -795,6 +804,9 @@ data:
- containerPort: ${USER_CONTAINER_PORT}
name: http
volumes:
{{- with $.Values.extraPodVolumes }}
{{- toYaml . | nindent 14 }}
{{- end }}
{{- if $require_aws_config }}
- name: config-volume
configMap:
Expand Down Expand Up @@ -871,6 +883,10 @@ data:
imagePullPolicy: IfNotPresent
command: ${WORKER_COMMAND}
env: ${WORKER_ENV}
{{- with $.Values.extraPodEnvFrom }}
envFrom:
{{- toYaml . | nindent 16 }}
{{- end }}
resources:
requests:
{{- if eq $device "gpu" }}
Expand All @@ -887,6 +903,9 @@ data:
memory: ${MEMORY}
${STORAGE_DICT}
volumeMounts:
{{- with $.Values.extraPodVolumeMounts }}
{{- toYaml . | nindent 18 }}
{{- end }}
{{- if $require_aws_config }}
- name: config-volume
mountPath: /opt/.aws/config
Expand All @@ -908,6 +927,9 @@ data:
- containerPort: ${USER_CONTAINER_PORT}
name: http
volumes:
{{- with $.Values.extraPodVolumes }}
{{- toYaml . | nindent 14 }}
{{- end }}
{{- if $require_aws_config }}
- name: config-volume
configMap:
Expand Down Expand Up @@ -1093,6 +1115,9 @@ data:
{{- end }}
serviceAccountName: {{ $launch_name }}
volumes:
{{- with $.Values.extraPodVolumes }}
{{- toYaml . | nindent 12 }}
{{- end }}
{{- if $require_aws_config }}
- name: config-volume
configMap:
Expand Down Expand Up @@ -1128,6 +1153,10 @@ data:
{{- end }}
{{- end }}
imagePullPolicy: IfNotPresent
{{- with $.Values.extraPodEnvFrom }}
envFrom:
{{- toYaml . | nindent 14 }}
{{- end }}
command:
- dumb-init
- --
Expand Down Expand Up @@ -1159,6 +1188,9 @@ data:
memory: 32Gi
ephemeral-storage: 30Gi
volumeMounts:
{{- with $.Values.extraPodVolumeMounts }}
{{- toYaml . | nindent 16 }}
{{- end }}
{{- if $require_aws_config }}
- name: config-volume
mountPath: /opt/.aws/config
Expand Down Expand Up @@ -1221,6 +1253,9 @@ data:
serviceAccountName: {{ $launch_name }}
{{- end }}
volumes:
{{- with $.Values.extraPodVolumes }}
{{- toYaml . | nindent 12 }}
{{- end }}
{{- if $require_aws_config }}
- name: config-volume
configMap:
Expand Down Expand Up @@ -1273,6 +1308,9 @@ data:
memory: ${MEMORY}
${STORAGE_DICT}
volumeMounts:
{{- with $.Values.extraPodVolumeMounts }}
{{- toYaml . | nindent 16 }}
{{- end }}
{{- if $require_aws_config }}
- name: config-volume
mountPath: /opt/.aws/config
Expand All @@ -1292,6 +1330,10 @@ data:
env:
- name: AWS_CONFIG_FILE
value: "/opt/.aws/config"
{{- with $.Values.extraPodEnvFrom }}
envFrom:
{{- toYaml . | nindent 14 }}
{{- end }}
command:
- python
- -m
Expand All @@ -1311,6 +1353,9 @@ data:
cpu: 1
memory: 1Gi
volumeMounts:
{{- with $.Values.extraPodVolumeMounts }}
{{- toYaml . | nindent 16 }}
{{- end }}
{{- if $require_aws_config }}
- name: config-volume
mountPath: /opt/.aws/config
Expand Down
9 changes: 9 additions & 0 deletions charts/model-engine/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,15 @@ extraEnvVars: [] # Extra env vars for all main containers (gateway,
extraVolumes: [] # Extra volumes for all deployments
extraVolumeMounts: [] # Extra volume mounts for main containers
extraPodEnvFrom: [] # Extra envFrom for inference pods (e.g., MinIO credentials)
# Extra volumes for every workload the service template renders that reads object
# storage: the endpoint Deployment, both halves of a LeaderWorkerSet, the batch jobs and
# the input-downloader initContainer. Distinct from extraVolumes above, which only
# reaches the control-plane deployments. These pod specs have a fixed volume list, so a
# site that has to hand them a file (a private CA for an S3 endpoint, say) has no other
# way in: extraPodEnvFrom carries env only, and both existing mounts use subPath/items
# and project a single named key.
extraPodVolumes: []
extraPodVolumeMounts: []

# PVC-backed model cache for endpoint pods. When enabled, model downloads are cached on
# one endpoint-scoped PVC instead of the pod's ephemeral storage. The default access
Expand Down