drop: remove access to Predef.any2stringadd
#24656
Draft
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
added
the
stat:needs decision
hamzaremmal
added
the
needs-minor-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: This PR might be controversial and we will probably have to debate it and set precedence on how to handle such changes.
In this PR, we break source compatibility (but not backwards binary compatibility) by removing access to the
Predef.any2stringaddimplicit class. It was deprecated in Scala 2.13, not imported by default in Scala 3 (behaviour that was documented nowhere). As such, and as part of cleaning up the stdlib, we drop access to it while keeping it public in the bytecode. I have also removed the implicit keyword since I've undone the logic in the compiler that removes it from the root import and it might be availablescalapackage and sub-packages (which goes against the point).Closes #8830