Add freeze wrapper (2) #24518
Merged
Add freeze wrapper (2) #24518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: drop redundant statement in captureSetImpliedByFields
Still missing: Make Mutable an Unscoped
Fix: the APPLY rule had to be changed so that it does not kick in if the result has Unscoped capabilities. These need to be preserved, we cannot approximate by the (possibly pure) function type.
Caught one bug in CaptureSet
That way we can also freeze read-only Mutables. Also: Adapt boxes and double flip tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised version of #24423.
Based on #24495.