Skip to content

Relax flow typing checks on Flexible Types #24278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

Relax flow typing checks on Flexible Types #24278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/core/NullOpsDecorator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ object NullOpsDecorator:

/** Is self (after widening and dealiasing) a type of the form `T | Null`? */
def isNullableUnion(using Context): Boolean = {
val stripped = self.stripNull()
val stripped = self.stripNull(stripFlexibleTypes = false)
stripped ne self
}
end extension
Expand Down
9 changes: 9 additions & 0 deletions tests/explicit-nulls/pos/flow-flexible.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// This test is based on sconfig/sconfig/shared/src/main/scala/org/ekrich/config/impl/SimpleConfig.scala
// In cases where a nullable variable is assigned a flexible type, we want
// later code to type the variable access as non-nullable
// Added in https://github.com/scala/scala3/pull/24278

def main() =
var result: String | Null = null
result = "".trim()
result.trim()
Loading