Show secret error in includes - #48
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The error-chain changes are coherent and comprehensively covered without identified correctness issues.
Review effort: Balanced
Findings: None
What changed in this PR
Improves missing-secret diagnostics, including errors originating in included templates.
Changes:
- Preserves error chains through template rendering and PostgreSQL execution.
- Reports configured secret names, source paths, line numbers, and documentation links.
- Adds unit, migration-build, integration, and documentation-link coverage.
| File | Description |
|---|---|
src/template.rs |
Uses real template paths in rendering errors. |
src/secrets.rs |
Improves undefined-secret diagnostics. |
src/docs.rs |
Centralizes documentation URLs. |
src/lib.rs |
Exports the documentation module. |
src/engine/mod.rs |
Preserves underlying database error chains. |
src/engine/postgres_psql.rs |
Retains streaming failure context. |
src/commands/migration/apply.rs |
Verifies full-chain secret redaction. |
tests/migration_build.rs |
Tests included-template build diagnostics. |
tests/integration_postgres.rs |
Tests apply-time diagnostics and failure recording. |
tests/doc_links.rs |
Validates documentation link targets. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a secret is missing in an include, the error is unhelpful. This fixes it so the underlying error is visible.