Remove completion command and related docs/tests#7
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis pull request removes shell completion functionality from the project. The changes eliminate Homebrew completion documentation and usage examples from the README, remove custom shell completion configuration from the CLI root command setup, and delete the corresponding integration test that validated completion output across multiple shell types. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes the CLI’s shell completion command surface area and its related documentation/tests, aligning the repo with the decision to no longer expose or validate completion script generation.
Changes:
- Disables shell completion command registration in the root CLI command.
- Removes the completion integration test.
- Removes shell completion documentation from the README.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/cli/cli.go | Stops enabling/configuring the framework-provided shell completion command on the root command. |
| internal/cli/cli_integration_test.go | Deletes the integration test that exercised git-worktreeinclude completion <shell>. |
| README.md | Removes Homebrew completion note and the completion command documentation/examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Verification
go test ./...Summary by CodeRabbit
Release Notes
Documentation
Chores