Skip to content

Remove completion command and related docs/tests#7

Merged
satococoa merged 1 commit intomainfrom
codex/remove-completion-command
Mar 5, 2026
Merged

Remove completion command and related docs/tests#7
satococoa merged 1 commit intomainfrom
codex/remove-completion-command

Conversation

@satococoa
Copy link
Copy Markdown
Owner

@satococoa satococoa commented Mar 5, 2026

Summary

  • disable shell completion command registration in CLI
  • remove completion integration test
  • remove completion documentation from README

Verification

  • go test ./...

Summary by CodeRabbit

Release Notes

  • Documentation

    • Removed shell completion setup instructions and examples.
  • Chores

    • Removed shell completion configuration from the application.
    • Removed shell completion test coverage.

Copilot AI review requested due to automatic review settings March 5, 2026 14:52
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a47ca0bf-3a03-42a4-a47c-a53a9dbf24e3

📥 Commits

Reviewing files that changed from the base of the PR and between 0ea7981 and 99e89be.

📒 Files selected for processing (3)
  • README.md
  • internal/cli/cli.go
  • internal/cli/cli_integration_test.go
💤 Files with no reviewable changes (2)
  • README.md
  • internal/cli/cli_integration_test.go

📝 Walkthrough

Walkthrough

This pull request removes shell completion functionality from the project. The changes eliminate Homebrew completion documentation and usage examples from the README, remove custom shell completion configuration from the CLI root command setup, and delete the corresponding integration test that validated completion output across multiple shell types.

Changes

Cohort / File(s) Summary
Shell Completion Removal
README.md, internal/cli/cli.go, internal/cli/cli_integration_test.go
Removed shell completion documentation from README, removed custom EnableShellCompletion and ConfigureShellCompletionCommand configuration from CLI setup, and deleted the TestCompletionCommand integration test that validated multi-shell completion output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰 Hoppity-hop, the completions take flight,
Shell scripts and tests vanish from sight,
A cleaner config, so neat and so light,
Less magic means more clarity bright! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing the completion command along with its documentation and tests across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/remove-completion-command

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the CLI’s shell completion command surface area and its related documentation/tests, aligning the repo with the decision to no longer expose or validate completion script generation.

Changes:

  • Disables shell completion command registration in the root CLI command.
  • Removes the completion integration test.
  • Removes shell completion documentation from the README.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
internal/cli/cli.go Stops enabling/configuring the framework-provided shell completion command on the root command.
internal/cli/cli_integration_test.go Deletes the integration test that exercised git-worktreeinclude completion <shell>.
README.md Removes Homebrew completion note and the completion command documentation/examples.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@satococoa satococoa merged commit bd9549e into main Mar 5, 2026
9 checks passed
@satococoa satococoa deleted the codex/remove-completion-command branch March 5, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants