Always keep EEG data in Volts instead of converting to mV#102
Merged
sappelhoff merged 5 commits intosappelhoff:masterfrom Aug 4, 2021
Merged
Always keep EEG data in Volts instead of converting to mV#102sappelhoff merged 5 commits intosappelhoff:masterfrom
sappelhoff merged 5 commits intosappelhoff:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 99.04% 99.04% -0.01%
==========================================
Files 7 7
Lines 736 734 -2
==========================================
- Hits 729 727 -2
Misses 7 7 ☔ View full report in Codecov by Sentry. |
sappelhoff
approved these changes
Aug 4, 2021
Owner
|
Thanks @a-hurst! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR removes a bunch of unnecessary conversions back and forth between Volts and mV, likewise changing the units for a few user-facing EEG attributes (e.g.
self.EEG_before_interpolation) inPrepPipelinefrom the EEGLAB standard of mV to the MNE standard of volts.This should make the API less confusing for people used to working in the MNE world, avoid a bunch of unnecessary large matrix multiplication, and makes some other proposed API changes in #99 easier to implement.
Merge Checklist
closes #<issue-number>to automatically close an issue