sync fork master#12
Open
Carthaca wants to merge 87 commits into
Open
Conversation
Copy-paste issues with code-block::console, changing to bash Change-Id: I857fcba4db74f19087529c6183dc67a888735209
Pull the latest content in manila repo to use the consistent setting across repos. Change-Id: Ib0d3678f558b273df5b4cb6d389f2073afd3fca8
Python 3.9 is no longer part of the tested runtimes[1]. [1] https://governance.openstack.org/tc/reference/runtimes/2025.2.html Change-Id: Id6a260410e0f7b1f9edf0b9b7a4ae73bceb5f44b
Devstack has removed the USE_PYTHON3 variable[1][2] and now always uses Python 3. [1] https://review.opendev.org/c/openstack/devstack/+/920658 [2] Commit 5412dbfe7b797149f1f68100de8003b1876398fe Change-Id: If18479450113ba766262b1ca7ddb001e57408a65
Messages had positive tests, this commit introduces the negative tests for the messages. Change-Id: I4c7f75e470005e00a78f9e5c27bb4b7c3b67b1e7 Signed-off-by: Riane Torres <riane.torres@gmail.com>
Fixed negative user message test names (test_delete_message_invalid_id & test_show_message_missing_id) This amended commit is a follow up to another change. Also removed __init__.py file Change-Id: I7abccf64b6fa8d69c347d65c801da72763966a4e Signed-off-by: Riane Torres <riane.torres@gmail.com>
Provide an option to override API endpoint to address multiple manila deployments on same cloud. Usage as following: "openstack --os-endpoint-override <endpoint_url> share list" Closes-bug: #2111331 Co-authored-by: Chuan Miao <chuan.miao@sap.com> Change-Id: I5e11256473ab88b08e7374fd68f58a0257adab1f Signed-off-by: Kiran Pawar <kinpaa@gmail.com>
Implemented encryption_key_ref option for share create API from microversion 2.90. Added encryption_keys quota set support. partially-implements: blueprint share-encryption Change-Id: I54caefb77cb4d5af3fa7d4527592cf60f09b54c4 Signed-off-by: Kiran Pawar <kinpaa@gmail.com>
Add CLI support and tests for performing a restore operation with Manilas share backup API that targets a non-source share i.e. a share other then that used to create the backup.) Partially-Implements: blueprint out-of-place-restore Depends-On: I060b0dc579e3057f2cb046ebe3271287f8fbc9f9 Change-Id: I8414c62010cd369e27cc5b693612c59d4e7516a3 Signed-off-by: Zachary Goggin <zachary.goggin@cern.ch>
A typo in the URL for ensure shares was created and the API endpoint did not match as a result. Fixed the issue by replacing '_' by '-' to match the endpoint correctly. Closes-bug: #2109376 Change-Id: I025d0f853bced49a2d484dc75db809b3d7edb498 Signed-off-by: Carlos da Silva <ces.eduardo98@gmail.com>
Add file to the reno documentation build to show release notes for stable/2025.2. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/2025.2. Sem-Ver: feature Change-Id: I16d12c811f12e1de4301ac38f4c9bf992f82b5fa Signed-off-by: OpenStack Release Bot <infra-root@openstack.org> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/add_release_note_page.sh
This change adds the --wait flag to the share-server-unmanage command, allowing users to wait for the asynchronous operation to complete before returning to the command prompt. When --wait is specified, share-server-unmanage waits until the server is removed. Closes-Bug: #1898315 Change-Id: I90f9c7048a1d5cc21064c4b1d000732dc5fd50d6 Signed-off-by: Premlata <premlata84277@gmail.com>
The osc commands `openstack share set <share-id> --task-state` and `openstack share server set <share-server-id> --task-state` were failing when no value was provided, or when None was passed as an argument, leading to the API receive the string "null" instead of the JSON null value. This change makes the --task-state argument optional, allowing it to be specified without a value or with the string "None". In both cases, the command correctly interprets these inputs as a request to clear the task state by sending a proper null value to the API. Test Plan: - Added unittests for --task-state argument handling both share set and share server set commands. - Verified cases when --task-state is provided without a value (interpreted as None) or with value "None" (ensuring it is properly converted to None). Closes-Bug: #2108991 Change-Id: Ic2a9eed81154bfbe8517c7411da72f1e4d0e1e64 Signed-off-by: llmtech-dev <llm.tech.developer@gmail.com>
when initializing manila python client, the region name was being ignored. As a result, the client could connect to the wrong region endpoint. This change ensures that region name is passed to session.get_endpoint() so the correct endpoint is used. Test, -Updated unit tests to verify that the region name is respected during client initialization. Closes-Bug: #2057951 Change-Id: I2d971f2c4771d62a1776c995ef8a16594fd04c99 Signed-off-by: denver-baraka <denverbaraka@gmail.com> Assisted-By: Copilot
The 'share network create' command previously attempted to fetch the subnet directly, which could lead to errors when the neuron network data was invalid or missing. This change updates the logic to properly handle invalid neutron network or subnet IDs during share network creation. Test Plan: - Added unit tests to verify valid and invalid neutron info. Closes-Bug: #2051394 Change-Id: Ib233f02ad94326d5b8ffadf962fb911d417b024a Signed-off-by: denver-baraka <denverbaraka@gmail.com> Assisted-By: Copilot
Change-Id: I10d630f70b543498b33045ba5819dc68be0e6960 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Change-Id: If0980b7a181fee04c832f6568cba00cba0626958 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Some of these are genuine bugs caused by missing imports. Change-Id: Iae120aaf0f2849ec6af941d764b8bd0ef8375a96 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Change-Id: I920dc4922056a807b4d25728560fb4f58cbf14c2 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Extend these into OSC capabilities where appropriate. Added metadata for create/show/set commands and implemented unset operation for unified CLI. Bumps max microversion to 2.95. Partially-implements: bp metadata-for-share-resources Depends-On: https://review.opendev.org/c/openstack/manila/+/973777 Change-Id: I29bd79340698c407be3113d76b4d05b31643c194 Signed-off-by: Saikumar Pulluri <saikumar1016@gmail.com>
This matches the behavior of novaclient [1], cinderclient [2] etc. We also fix a typo. [1] https://github.com/openstack/python-novaclient/blob/3e2dd5bd638352ac453d975ec2194315d4daea8f/novaclient/api_versions.py#L233-L234 [2] https://github.com/openstack/python-cinderclient/blob/1d8c7becaf2c1363afe843d2a5a86b1707a8e3ff/cinderclient/api_versions.py#L227-L228 Change-Id: I91b46474366248ae34df27fe35f63281602ae377 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Add file to the reno documentation build to show release notes for stable/2026.1. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/2026.1. Sem-Ver: feature Change-Id: Icddd583bf42e0a8e94745448fbf321e455b4c111 Signed-off-by: OpenStack Release Bot <infra-root@openstack.org> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/add_release_note_page.sh
Provide an option to override API endpoint to address multiple manila deployments on same cloud. Usage as following: "openstack --os-endpoint-override <endpoint_url> share list". Closes-bug: #2111331 Co-authored-by: Chuan Miao <chuan.miao@sap.com> Signed-off-by: Kiran Pawar <kinpaa@gmail.com> Change-Id: I7951055b4528908bafbe98f0707d9d89ed436862
Closes-Bug: #2146280 Closes-Bug: #2146288 Change-Id: Ia6e7d8e2794cb3c349082a27dba3b6bd692c146b Signed-off-by: Sally Karimi <karimisally905@gmail.com>
The OpenStack Client plugin documentation in osc_plugin_cli.rst incorrectly uses OS_TENANT_NAME as an example for environment variable. This patch updates it to OS_PROJECT_NAME to match current OpenStack conventions and ensure consistency. Closes-Bug: #2146286 Change-Id: Ie49a5ee798225357223de55c4fa2dddec85a7acf Signed-off-by: Denver Baraka <denverbaraka@gmail.com>
Some manager classes had errors in their docstring referencing wrong resource classes. This patch updates them to reference correct classes. - ShareReplicaExportLocationManager: ShareInstanceExportLocation > ShareReplicaExportLocation - AvailabilityZoneManager: Service > AvailabilityZone - ShareInstanceManager: ShareInstances > ShareInstance Closes-bug: #2146282 Change-Id: I7960eec25f5db9c5c6405bee0706752c1d1dc9fa Signed-off-by: Denver Baraka <denverbaraka@gmail.com>
fix copy-paste errors in share_networks.py and share_network_subnets.py manager classes by updating incorrect parameter names and return types. - policy > share_network / share_network_subnet - NetworkInfo > ShareNetwork - NetworkSubnetInfo > ShareNetworkSubnet Closes-bug: #2146281 Change-Id: I7aac0a31966667cc59d2da58d9edbc8250fabaea Signed-off-by: Denver Baraka <denverbaraka@gmail.com>
there were three minor formatting issues. Specifically, - 'share_delete' and 'share_lock_set' had leading spaces which could affect plugin loading. - 'share_group_snapshot_show' was missing a space before equal sign so not consistent with style. This change removes the leading spaces and adds the missing space for style consistency. Test Plan: PASS: tox -e pep8 Closes-Bug: #2146283 Change-Id: Id5948ac61f6b171b152de5a11aac4d7e99c901f1 Signed-off-by: Denver Baraka <denverbaraka@gmail.com>
The python-manila client README had some outdated references that didn't allign with current conventions. Specifically, this patch: - updates wording to explicitly mention "OpenStack Manila API" instead of "Rackspace compatible API" - replaces keystone v2 'tenant' with '--os-project-name' and 'OS_PROJECT_NAME' - updates keystone authentication URL examples from 'v2.0' to 'v3' - updatesthe python API quickstart snippet to import and use 'manilaclient.v2' and 'PROJECT' credentials. Closes-Bug: #2146284 Change-Id: Ibdf2601f70fb94274747a78e47708edc62cbd65c Signed-off-by: Denver Baraka <denverbaraka@gmail.com>
this change replaces the deprecated v1 client and '$OS_TENANT_NAME' with current standard of using v2 client and the '$OS_PROJECT_NAME' this change also corrects a minorr spelling error "assuumes" to "assumes" Closes-Bug: #2146285 Change-Id: I1314abb3476466df05093cc87775f5ac96fcefa9 Signed-off-by: Denver Baraka <denverbaraka@gmail.com>
Addressed comments from 973923 patch. Added functional and unit tests Patch link: https://review.opendev.org/c/openstack/python-manilaclient/+/973923 Change-Id: I10c5d23b698f6f3e8e20b911cd8a65b6e8585afb Co-authored-by: medhac1403 <medhaj06@gmail.com> Signed-off-by: Medha Choudhary <medhaj06@gmail.com>
From this patch, share migration feature is no longer considered experimental. The experimental headers were removed from the share migration client commands. DocImpact Partially-implements: bp graduate-share-migration-feature Change-Id: Ia0f9b7adadc27c94737d53a5304b276f4c9b0b9f Signed-off-by: medhac1403 <medhaj06@gmail.com>
... following the change in devstack[1]. [1] 6180e73702cfef2011c32f315cde97128a4b7eec Change-Id: Ia4a055a1aae4452abd712315b526aafdea51beff Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
kpawar-sap
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.