docs: remove stale sax-js references from README - #270
Merged
palemieux merged 1 commit intoSep 1, 2026
Conversation
Commit 665e022 removed sax from the browser path and dropped the imsc.all.* bundles, but the README still documented both. Update the RUNTIME DEPENDENCIES, QUICK START, API and BUILD sections to match: the native DOMParser is used by default, a custom parser can be passed to fromXML(), and dist contains imsc.debug.js, imsc.min.js and main/. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
palemieux
self-requested a review
September 1, 2026 16:06
palemieux
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 665e022 removed sax from the browser path and dropped the
imsc.all.*bundles, but the README still documents both. This updates the stale sections:DOMParseris used by default, and that environments without it (for example Node.js) must passfromXML()a parser that implements the contract insrc/main/js/parser.js.build/public_html/libs/sax.js, so the example now loads onlylibs/imsc.js.fromXML()entry documents the optionalparserargument added in 665e022.imsc.all.debug.jsandimsc.all.min.jsand now matches what rollup and tsc produce:imsc.debug.js,imsc.min.js, andmain/.Written against the current integration/v2 tip (665e022). #265 also edits the README for the grunt removal; this PR keeps the current grunt wording and leaves the lines #265 touches unchanged.
🤖 Generated with Claude Code