Skip to content

Fallback to default action icon #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fallback to default action icon #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35fecb2
Fallback to default action icon if action is not present in manifest.
Corchoneitor Nov 13, 2025
151169f
Simplify code.
Corchoneitor Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions packages/electron-chrome-extensions/src/browser/api/browser-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,21 +46,27 @@ const getBrowserActionDefaults = (extension: Electron.Extension): ExtensionActio
: manifest.manifest_version === 2
? manifest.browser_action
: undefined
if (typeof browserAction === 'object') {
const manifestAction: chrome.runtime.ManifestAction = browserAction
const action: ExtensionAction = {}

action.title = manifestAction.default_title || manifest.name
const iconPath = getIconPath(extension)

const iconPath = getIconPath(extension)
if (iconPath) action.icon = { path: iconPath }

if (manifestAction.default_popup) {
action.popup = manifestAction.default_popup
if (typeof browserAction === 'object') {
const manifestAction: chrome.runtime.ManifestAction = browserAction
const action: ExtensionAction = {
title: manifestAction.default_title || manifest.name,
...(iconPath && { icon: { path: iconPath } }),
...(manifestAction.default_popup && { popup: manifestAction.default_popup }),
}

return action
}

// Fallback: Create action icon for extensions without explicit action.
if (iconPath) {
return {
title: manifest.name,
icon: { path: iconPath },
}
}
}

interface ExtensionActionStore extends Partial<ExtensionAction> {
Expand Down