Protect against high memory usage in malformed CRAM files. - #2070
Open
jkbonfield wants to merge 1 commit into
Open
Protect against high memory usage in malformed CRAM files.#2070jkbonfield wants to merge 1 commit into
jkbonfield wants to merge 1 commit into
Conversation
Replication the 10,000 block limit in slices. We already had it for allocating Content IDs (which is 1 per block), but oddly not for the block pointers themselves. Also add a similar check for the container header too. These won't limit valid or real-world CRAM usage. Signed-off-by: James Bonfield <jkb@sanger.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replication the 10,000 block limit in slices. We already had it for allocating Content IDs (which is 1 per block), but oddly not for the block pointers themselves.
Also add a similar check for the container header too.
These won't limit valid or real-world CRAM usage.