Conversation
…n lighting handler
…ification lighting handler" This reverts commit 4fc30e8.
ssethhyy
changed the title
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Moderate issues remain in cellular-state handling, picker persistence and lifecycle cleanup, and notification-lighting behavior.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (3)
What changed in this PR
Adds state-aware Wi-Fi and cellular-data toggle actions, alongside configurable Ripple/Dash notification-lighting features.
Changes:
- Registers and executes connectivity toggle actions.
- Adds Ripple/Dash models, persistence, rendering, and service integration.
- Adds lighting settings, previews, manual positioning, and supporting resources.
| File | Summary |
|---|---|
app/src/main/res/values/strings.xml |
Adds action and lighting strings. |
app/src/main/res/drawable/rounded_crop_portrait_24.xml |
Adds the Dash icon. |
app/src/main/java/com/sameerasw/essentials/viewmodels/state/RippleSettings.kt |
Manages Ripple settings and position. |
app/src/main/java/com/sameerasw/essentials/viewmodels/state/DashSettings.kt |
Manages Dash settings. |
app/src/main/java/com/sameerasw/essentials/viewmodels/MainViewModel.kt |
Loads and forwards lighting settings. |
app/src/main/java/com/sameerasw/essentials/utils/OverlayHelper.kt |
Integrates overlay styles. |
app/src/main/java/com/sameerasw/essentials/utils/overlay/RippleOverlay.kt |
Animates Ripple overlays. |
app/src/main/java/com/sameerasw/essentials/utils/overlay/RippleGlitterView.kt |
Renders Ripple effects. |
app/src/main/java/com/sameerasw/essentials/utils/overlay/RippleConfigIo.kt |
Serializes Ripple configuration. |
app/src/main/java/com/sameerasw/essentials/utils/overlay/DashOverlay.kt |
Renders and animates Dash overlays. |
app/src/main/java/com/sameerasw/essentials/utils/overlay/DashConfigIo.kt |
Serializes Dash configuration. |
app/src/main/java/com/sameerasw/essentials/ui/features/lighting/pickers/EdgeLightingStylePicker.kt |
Adds Ripple/Dash style choices. |
app/src/main/java/com/sameerasw/essentials/ui/features/lighting/NotificationLightingSettingsUI.kt |
Adds lighting controls and previews. |
app/src/main/java/com/sameerasw/essentials/ui/core/sheets/EssentialsBottomSheet.kt |
Adds IME padding behavior. |
app/src/main/java/com/sameerasw/essentials/ui/activities/RipplePositionPickerActivity.kt |
Provides manual Ripple positioning. |
app/src/main/java/com/sameerasw/essentials/services/NotificationListener.kt |
Propagates lighting configuration. |
app/src/main/java/com/sameerasw/essentials/services/NotificationLightingService.kt |
Displays configured lighting overlays. |
app/src/main/java/com/sameerasw/essentials/services/handlers/NotificationLightingHandler.kt |
Handles accessibility overlay configuration. |
app/src/main/java/com/sameerasw/essentials/services/automation/executors/CombinedActionExecutor.kt |
Executes connectivity toggles. |
app/src/main/java/com/sameerasw/essentials/domain/model/RippleConfig.kt |
Defines Ripple configuration. |
app/src/main/java/com/sameerasw/essentials/domain/model/NotificationLightingStyle.kt |
Adds Ripple/Dash styles. |
app/src/main/java/com/sameerasw/essentials/domain/model/NotificationLightingRipplePosition.kt |
Defines Ripple positions. |
app/src/main/java/com/sameerasw/essentials/domain/model/DashConfig.kt |
Defines Dash configuration. |
app/src/main/java/com/sameerasw/essentials/domain/diy/ActionRegistry.kt |
Registers connectivity actions. |
app/src/main/java/com/sameerasw/essentials/domain/diy/Action.kt |
Defines toggle actions. |
app/src/main/java/com/sameerasw/essentials/data/repository/SettingsRepository.kt |
Adds lighting preference keys. |
app/src/main/AndroidManifest.xml |
Registers the position picker activity. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+913
to
+916
| result as? Boolean ?: false | ||
| } catch (e: Exception) { | ||
| e.printStackTrace() | ||
| false |
Comment on lines
+117
to
+120
| viewModel.ripple.savePositionXY( | ||
| newX.coerceIn(0f, 100f), | ||
| newY.coerceIn(0f, 100f), | ||
| ) |
Comment on lines
+18
to
+19
| RIPPLE, | ||
| DASH, |
Owner
|
@ssethhyy Hi! Appreciate the work.. Can you take a look at the conflicts and address them? |
sameerasw
marked this pull request as draft
September 22, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements new DIY actions for both Toggle Wi-Fi and Toggle Cellular Data
List of changes:
Action.ToggleWifiandAction.ToggleCellularDatatoAction.ktandActionRegistry.kt.isWifiEnabledusingWifiManager.isWifiEnabled.isCellularDataEnabledusingTelephonyManagerandHiddenApiBypass.CombinedActionExecutorto dynamically inspect current device status and toggle Wi-Fi / Cellular Data.Type of change
UI changes
N/A
Checklist
Before submitting, please make sure:
develop(notmain)../gradlew assembleDebug../gradlew testDebugUnitTest.SettingsRepositoryfor keys and getter/setter methods.FeatureRegistry.ktfor search indexing.ui/core/(RoundedCardContainer,IconToggleItem, etc.).res/values/strings.xmland drawables use rounded variants (R.drawable.rounded_*).