Skip to content

[fix] Title and author text is now clipped to prevent drawing outside the island - #1108

Open
johnseagull3326 wants to merge 2 commits into
sameerasw:developfrom
johnseagull3326:fix/island-text-clipping
Open

johnseagull3326 wants to merge 2 commits into
sameerasw:developfrom
johnseagull3326:fix/island-text-clipping

Conversation

@johnseagull3326

@johnseagull3326 johnseagull3326 commented Sep 20, 2026

Copy link
Copy Markdown

Description

Title and author text now use TextUtils.ellipsize instead of drawing outside of the expanded island overlay

Was tested on a physical Pixel 8 Pro at various settings.

Type of change

  • Bug fix
  • New feature
  • UI / visual update
  • Performance improvement
  • Refactoring / cleanup
  • Translations
  • Build / CI tooling

UI changes

Screenshot_20260920-162353 Screenshot_20260920-163103

Text now gets clipped using ellipsis instead of overflowing beyond the border of the overlay

Checklist

Before submitting, please make sure:

  • The base branch is set to develop (not main).
  • The app builds cleanly locally with ./gradlew assembleDebug.
  • Unit tests pass with ./gradlew testDebugUnitTest.
  • You tested the changes on a device or emulator (including Shizuku or Root if applicable).
  • New preferences use SettingsRepository for keys and getter/setter methods.
  • New user-facing settings are registered in FeatureRegistry.kt for search indexing.
  • New UI follows the design system in ui/core/ (RoundedCardContainer, IconToggleItem, etc.).
  • Strings are added to res/values/strings.xml and drawables use rounded variants (R.drawable.rounded_*).

@johnseagull3326 johnseagull3326 changed the title Title and author text is now clipped to prevent drawing outside the island [fix] Title and author text is now clipped to prevent drawing outside the island Sep 20, 2026
@sameerasw sameerasw added the bug Something isn't working label Sep 21, 2026
@sameerasw sameerasw moved this from Backlog to In review in Essentials Progress Sep 21, 2026
@sameerasw

Copy link
Copy Markdown
Owner

Ohhh I remember seeing this overflow... Will it be possible to use the marquee effect instead of ellipses?

@johnseagull3326
johnseagull3326 marked this pull request as draft September 21, 2026 17:16
@johnseagull3326
johnseagull3326 marked this pull request as ready for review September 21, 2026 17:22
@johnseagull3326

Copy link
Copy Markdown
Author

Done.

Demo video:
https://github.com/user-attachments/assets/c62c7d83-a163-45f3-8b45-a2f678dc77f8

Modified the marquee text method to make it able to draw centered text when the marquee effect isn't required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants