[fix] Title and author text is now clipped to prevent drawing outside the island - #1108
Open
johnseagull3326 wants to merge 2 commits into
Open
johnseagull3326 wants to merge 2 commits into
johnseagull3326 wants to merge 2 commits into
Conversation
Owner
|
Ohhh I remember seeing this overflow... Will it be possible to use the marquee effect instead of ellipses? |
johnseagull3326
marked this pull request as draft
September 21, 2026 17:16
johnseagull3326
marked this pull request as ready for review
September 21, 2026 17:22
Author
|
Done. Demo video: Modified the marquee text method to make it able to draw centered text when the marquee effect isn't required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Title and author text now use
TextUtils.ellipsizeinstead of drawing outside of the expanded island overlayWas tested on a physical Pixel 8 Pro at various settings.
Type of change
UI changes
Text now gets clipped using ellipsis instead of overflowing beyond the border of the overlay
Checklist
Before submitting, please make sure:
develop(notmain)../gradlew assembleDebug../gradlew testDebugUnitTest.SettingsRepositoryfor keys and getter/setter methods.FeatureRegistry.ktfor search indexing.ui/core/(RoundedCardContainer,IconToggleItem, etc.).res/values/strings.xmland drawables use rounded variants (R.drawable.rounded_*).