3006.x: enable nightly stress test - #70099
Merged
Merged
Conversation
charzl
changed the title
2 tasks
charzl
changed the title
charzl
changed the title
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
twangboy
previously approved these changes
Aug 21, 2026
dwoz
requested changes
Aug 21, 2026
The previous wording described a rename to run-stress-test.yml and a new dispatcher file -- that belongs to PR #70103, not this PR. This PR only modifies nightly-stress-test.yml in place. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of VCOPS-100029 (run a stress test against a specific PR/branch on demand). Companion to #70087 (master) -- the master dispatcher fires this branch's own copy of the (renamed) workflow nightly via
workflow_dispatch --ref 3006.x, matching the--ref matrix.branchpattern already used byrun-nightly.yml'strigger-branch-nightly-buildsjob.Daniel Wozniak (core maintainer) confirmed
workflow_dispatch --ref Xruns the copy of the target workflow file that exists on branch X -- so this file has to actually live on3006.xitself for a3006.x-targeted nightly dispatch to pick up any future change made here, rather than silently falling back to whatevermaster's copy says.nightly-stress-test.yml->run-stress-test.yml(drops the deadschedule:trigger -- GitHub only honorsschedule:off the repo's default branch, so it never fired on this branch anyway).branchinput (default3006.x), used tocheckoutthe actual code under test -- lets this be invoked against an arbitrary branch/PR, not just this one.stress-snapshotsrun dir withinputs.branch, matching master's copy.nightly-stress-test.yml(dispatcher), byte-identical to master's copy in [DRAFT]Dispatch nightly-stress-test.yml per-branch (master/3006.x/3008.x), each against its own --ref #70087. Only master's copy is ever actually fired by theschedule:cron, but master's dispatcher callsgh workflow run run-stress-test.yml --ref 3006.x, andworkflow_dispatch --ref Xrequires the target workflow (run-stress-test.yml) to exist on branch X -- so without this file's siblingrun-stress-test.ymlbeing dispatchable, and without this dispatcher itself present here for manual/parity testing, that call would 404. Keeping it byte-identical across branches means porting to3007.x/3008.xlater is a straight copy, not a re-derivation.Test plan
pre-commithooks pass.workflow_dispatchofrun-stress-test.yml(manually, and via the master dispatcher once [DRAFT]Dispatch nightly-stress-test.yml per-branch (master/3006.x/3008.x), each against its own --ref #70087 merges) runs successfully against this branch.Result: https://github.com/saltstack/salt/actions/runs/32336235859