[Draft] 3008.x: rename nightly-stress-test.yml to run-stress-test.yml, add branch input - #70088
Closed
charzl wants to merge 1 commit into
Closed
[Draft] 3008.x: rename nightly-stress-test.yml to run-stress-test.yml, add branch input#70088charzl wants to merge 1 commit into
charzl wants to merge 1 commit into
Conversation
Drops the schedule: trigger (dead on this non-default branch anyway -- GitHub only honors schedule off the repo's default branch) and adds a required branch input (default 3008.x) so this can be invoked with --ref 3008.x from the dispatcher in saltstack/salt's nightly-stress-test.yml (VCOPS-100029's nightly coverage) as well as manually against any branch/ PR diff. Keeps this branch's own enable_metrics/worker_threads inputs and Configure salt-master step as-is. Branch-qualifies the Docker cache key, artifact name, and stress-snapshots run dir with inputs.branch, matching the same pattern on master's copy of this file.
Closed
2 tasks
charzl
changed the title
Collaborator
Author
|
Closing — went with Option A (single source of truth on master, dispatched via --ref master + inputs.branch) instead of per-branch copies. 3008.x's enable_metrics/worker_threads inputs have been folded into master's run-stress-test.yml as universal opt-in inputs instead (see #70087), so this branch doesn't need its own copy of the file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of VCOPS-100029 (run a stress test against a specific PR/branch on demand). Companion to #70087 (master), which adds a
nightly-stress-test.ymldispatcher on master that fires this branch's own copy of the (renamed) workflow nightly viaworkflow_dispatch --ref 3008.x, matching the--ref matrix.branchpattern already used byrun-nightly.yml'strigger-branch-nightly-buildsjob.nightly-stress-test.yml->run-stress-test.yml(drops the deadschedule:trigger -- GitHub only honorsschedule:off the repo's default branch, so it never fired on this branch anyway).branchinput (default3008.x), used tocheckoutthe actual code under test -- lets this be invoked against an arbitrary branch/PR, not just this one.enable_metrics/worker_threadsinputs andConfigure salt-masterstep as-is (not merged/aligned with master's simpler copy -- intentionally left divergent per-branch).stress-snapshotsrun dir withinputs.branch, matching master's copy.Test plan
pre-commithooks pass.workflow_dispatch(manually, and via the master dispatcher once [DRAFT]Dispatch nightly-stress-test.yml per-branch (master/3006.x/3008.x), each against its own --ref #70087 merges) runs successfully against this branch.