GPG: Attempt update if subkey is expired#69195
Open
lkubb wants to merge 1 commit into
Open
Conversation
lkubb
force-pushed
the
fix-gpg-subkey-refresh
branch
from
cd26df3 to
25eaba1
Compare
lkubb
force-pushed
the
fix-gpg-subkey-refresh
branch
from
25eaba1 to
8eecb94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes
gpg.presentkey refresh behavior account for expired subkeys.Key refreshes were added in 3008 only (via #66316), which should have included this behavior from the start. For this reason, I'm considering this PR a follow-up fix to a previously unreleased PR and hence did not create a changelog fragment.
What issues does this PR fix or reference?
Ref: #66314
Previous Behavior
Expired subkeys do not lead to key update
New Behavior
Recently expired subkeys lead to a key refresh attempt
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes