fix(kernelpkg_linux_apt): handle kernelrelease with '+' in _kernel_type (#69131)#69194
Open
SAY-5 wants to merge 1 commit into
Open
fix(kernelpkg_linux_apt): handle kernelrelease with '+' in _kernel_type (#69131)#69194SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
…pe (saltstack#69131) Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
kernelpkg_linux_apt._kernel_typefor Debian 13 (trixie) and other distros that ship akernelreleasecontaining a+(for example6.12.86+deb13-amd64). The regex now accepts the wider set of characters that modern Debian/Ubuntu kernels use, sokernelpkg.upgradeno longer raisesAttributeError: 'NoneType' object has no attribute 'group'.What issues does this PR fix or reference?
Fixes #69131
Previous Behavior
kernelpkg.upgradecrashed on Debian 13 withAttributeError: 'NoneType' object has no attribute 'group'becausere.match(r"^[\d.-]+-(.+)$", "6.12.86+deb13-amd64")returnedNone.New Behavior
_kernel_typereturns the kernel suffix (e.g.amd64) on the existing fixtures and on the trixie release. A regression test pins the trixie input.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No