Updated salt/modules/disk.py to fix postPrefixes by a factor of 10. p…#65543
Open
vib795 wants to merge 1 commit into
Open
Updated salt/modules/disk.py to fix postPrefixes by a factor of 10. p…#65543vib795 wants to merge 1 commit into
vib795 wants to merge 1 commit into
Conversation
Contributor
|
We'll need unit tests around |
s0undt3ch
added
the
needs-testcase
Author
|
@s0undt3ch added unit test for the PR |
Contributor
|
@vib795 IMHO, just a minor thought, but it may be more symmetrical and slightly easier to read if they are formatted the same way |
twangboy
requested changes
Apr 1, 2025
twangboy
left a comment
twangboy
left a comment
Contributor
There was a problem hiding this comment.
This needs a changelog. Please migrate the test to pytests.
twangboy
added
needs-changelog
Tests
test:full
Contributor
|
Please add a changelog, rebase, and resolve conflicts |
twangboy
previously approved these changes
Jul 2, 2026
postPrefixes used "10E3" (=10000) instead of "1E3" (=1000), causing all values with K/M/G/T/P/E/Z/Y suffixes to be inflated by a factor of 10. Fix multipliers and add pytest parametrized tests. Fixes: saltstack#65490
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes: #65490
Previous Behavior
1.0K gives 10000.0
New Behavior
1.0K should give 1000.0
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.