@W-22439379: remove secrets#1673
Conversation
| if (showSecretsEnvVarIsSet) { | ||
| this.warn(secretsMessages.getMessage('temp.envVarIsSet', ['sf org list'])); | ||
| } else { | ||
| this.warn(secretsMessages.getMessage('temp.envVarWorkaround', ['sf org list'])); |
There was a problem hiding this comment.
nit:
could it print the warning all the time instead of only for --json?
it's an old command so most --json calls are likely being piped to jq or something else, users updating to latest and running sf org list in their local machines could notice the message earlier.
There was a problem hiding this comment.
The HRO doesn't show tokens though. I think it would be confusing to have a warning about redacted messages when none are displayed.
My thought was that if someone is piping an AT from org list, it will fail because the accessToken will now be the redacted message. They will then likely see the warnings since warnings are sent to stderr
There was a problem hiding this comment.
ahh right, forgot it's actually a breaking change. Nvm 👍🏼
What does this PR do?
accessTokenandpasswordfromsf org list --jsonoutputaccessTokenfromsf org create scratch --jsonandsf org resume scratch --jsonoutputSF_TEMP_SHOW_SECRETS=trueenv var as a temporary workaround for CI pipelines that depend on these valuesmessages/secrets-redacted.mdfor reuse across commandsRelated
sf org auth show-*commands)Test plan
sf org list --jsonno longer shows real access tokenssf org create scratch --jsonno longer shows access tokensf org resume scratch --jsonsame as aboveSF_TEMP_SHOW_SECRETS=truerestores original behavior with deprecation warningyarn testWhat issues does this PR fix or reference?
@W-22439379@