Skip to content

Conversation

@LihaoLiuXs
Copy link
Collaborator

@LihaoLiuXs LihaoLiuXs commented Dec 9, 2025

Summary

Conformance tested for aws and gcp.

< Provide a brief description of the changes in this PR >

Some conventions to follow

  1. add the module name as a prefix
    • for example: add a prefix: docstore: for document store module, blobstore for Blob Store module
  2. for a test only PR, add test:
  3. for a perf improvement only PR, add perf:
  4. for a refactoring only PR, add "refactor:"

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.18%. Comparing base (30af604) to head (21e25a3).

Files with missing lines Patch % Lines
.../salesforce/multicloudj/blob/aws/AwsBlobStore.java 66.66% 1 Missing and 1 partial ⚠️
...lesforce/multicloudj/blob/client/BucketClient.java 60.00% 2 Missing ⚠️
.../multicloudj/blob/aws/async/AwsAsyncBlobStore.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #195      +/-   ##
============================================
+ Coverage     83.16%   83.18%   +0.01%     
  Complexity       91       91              
============================================
  Files           150      150              
  Lines          8145     8182      +37     
  Branches        944      948       +4     
============================================
+ Hits           6774     6806      +32     
- Misses          923      926       +3     
- Partials        448      450       +2     
Flag Coverage Δ
unittests 83.18% <86.48%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LihaoLiuXs LihaoLiuXs changed the title Implement the DoDoesBucketExist for Blob Implement the DoesBucketExist for Blob Dec 9, 2025
@sandeepvinayak sandeepvinayak changed the title Implement the DoesBucketExist for Blob blobstore: Implement the DoesBucketExist for Blob Dec 10, 2025
@LihaoLiuXs
Copy link
Collaborator Author

Codecov Report

❌ Patch coverage is 70.27027% with 11 lines in your changes missing coverage. Please review. ✅ Project coverage is 83.08%. Comparing base (3610b57) to head (1b27052). ⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...lesforce/multicloudj/blob/client/BucketClient.java 20.00% 4 Missing ⚠️
...lticloudj/blob/async/client/AsyncBucketClient.java 0.00% 3 Missing ⚠️
.../salesforce/multicloudj/blob/aws/AwsBlobStore.java 66.66% 1 Missing and 1 partial ⚠️
.../multicloudj/blob/aws/async/AwsAsyncBlobStore.java 85.71% 0 Missing and 1 partial ⚠️
...oudj/blob/async/driver/AbstractAsyncBlobStore.java 0.00% 1 Missing ⚠️
❌ Your patch status has failed because the patch coverage (70.27%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #195      +/-   ##
============================================
- Coverage     83.14%   83.08%   -0.06%     
  Complexity       91       91              
============================================
  Files           150      150              
  Lines          8134     8171      +37     
  Branches        945      949       +4     
============================================
+ Hits           6763     6789      +26     
- Misses          923      932       +9     
- Partials        448      450       +2     

Flag Coverage Δ
unittests 83.08% <70.27%> (-0.06%) ⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

Patch test coverage increased to 86%.

Comment on lines 1 to 9
{
"id" : "53ad5ca5-5655-401b-a5e2-0dc2e553d25c",
"name" : "storage_v1_b_substrate-sdk-gcp-poc1-test-bucket",
"request" : {
"url" : "/storage/v1/b/substrate-sdk-gcp-poc1-test-bucket?projection=full",
"method" : "GET"
},
"response" : {
"status" : 200,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the test ran twice in recording mode for gcp, there are duplicate recordings in the PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I updated the recording files for gcp.

@sandeepvinayak sandeepvinayak merged commit a6ad1d7 into salesforce:main Dec 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants