ci: pin dtolnay/rust-toolchain action to commit SHA - #104
Merged
Conversation
Replace the mutable @stable ref (check + bench jobs) with the pinned commit SHA 4360b52 it currently resolves to. Removes a supply-chain exposure: a compromise of the upstream action or its stable ref would otherwise execute in CI with a read-write GITHUB_TOKEN on push to main. CWE-1357 / CWE-353. Found via Frontier Strike WS2 OSS scan.
|
Thanks for the contribution! Before we can merge this, we need @SreeramGarlapati to sign the Salesforce Inc. Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin
dtolnay/rust-toolchainto the commit SHA4360b52(what@stablecurrently resolves to) in both thecheckandbenchjobs.Why
@stableis a mutable ref. A compromise of the upstream action or a re-point of itsstableref would execute attacker-controlled code in CI — with a read-writeGITHUB_TOKENon push tomain(secret exfil, artifact injection). Pinning to an immutable SHA closes this. CWE-1357 / CWE-353.Found via Frontier Strike WS2 OSS scan. No behavior change — same commit
@stablepoints to today.