Skip to content

Detect pending tab navigations for popup domain suggestions#544

Draft
Copilot wants to merge 4 commits into
masterfrom
copilot/enhancement-detect-url-changes
Draft

Detect pending tab navigations for popup domain suggestions#544
Copilot wants to merge 4 commits into
masterfrom
copilot/enhancement-detect-url-changes

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 19, 2026

Popup domain suggestions previously depended on tabs.onUpdated, so they could lag while a page was still loading. This change tracks main-frame navigation earlier via webNavigation, while falling back to the current document URL if navigation is cancelled.

  • Navigation tracking

    • Subscribe to webNavigation main-frame events in TabManager.
    • Update tracked tab URL on navigation start/commit/history/fragment updates.
    • Reload tab data on navigation errors when the pending URL did not commit.
  • Extension permissions

    • Add webNavigation permission across supported manifests.
  • Test coverage

    • Add focused TabManager tests for:
      • pending main-frame URL updates
      • ignoring sub-frame navigations
      • reverting to current document URL after navigation failure
api.webNavigation.onBeforeNavigate.addListener(TabManager.handleNavigationStarted);
api.webNavigation.onCommitted.addListener(TabManager.handleNavigationCommitted);
api.webNavigation.onErrorOccurred.addListener(TabManager.handleNavigationError);

Copilot AI and others added 3 commits May 19, 2026 12:03
Agent-Logs-Url: https://github.com/salarcode/SmartProxy/sessions/ce813f92-b526-45e7-b41c-0b2152e4e5a2

Co-authored-by: salarcode <1272095+salarcode@users.noreply.github.com>
Agent-Logs-Url: https://github.com/salarcode/SmartProxy/sessions/ce813f92-b526-45e7-b41c-0b2152e4e5a2

Co-authored-by: salarcode <1272095+salarcode@users.noreply.github.com>
Agent-Logs-Url: https://github.com/salarcode/SmartProxy/sessions/ce813f92-b526-45e7-b41c-0b2152e4e5a2

Co-authored-by: salarcode <1272095+salarcode@users.noreply.github.com>
Copilot AI changed the title [WIP] Enhance popup menu for domain suggestion during navigation Detect pending tab navigations for popup domain suggestions May 19, 2026
Copilot AI requested a review from salarcode May 19, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[enhancement] Detect url changes to enable domain suggestion on popup menu before tab loading is completed

2 participants