Closed
Conversation
|
Nice work! could this be restructured to use pybind11 and pre-build the all teh code so it would run without a compiler or any other dependencies? I've done that with Cython (#14) -- because that's what I'm used to -- but pybind11 would probably make cleaner binding code. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for porting this to C++.
This PR changes the compilation to pybind11 and cppimport.
In this way, it becomes really easy to install and run, e.g. running
will just work (assuming you have
cppimportinstalled): it will automatically compilesrc/main/cpp/concaveman.cppand load it.The code for passing in and returning the arrays also becomes a lot simpler.
Not directly related to this change: I added a
DEBUGflag for removing thestd::coutprintouts, and fixed one compiler warning for a missing typedef.