Skip to content

fix(security): redact CLI credential output - #231

Merged
saagpatel merged 3 commits into
mainfrom
codex/resolve-codeql-sensitive-data-20260821
Aug 21, 2026
Merged

fix(security): redact CLI credential output#231
saagpatel merged 3 commits into
mainfrom
codex/resolve-codeql-sensitive-data-20260821

Conversation

@saagpatel

Copy link
Copy Markdown
Owner

Summary

  • redact credential-shaped values at the shared CLI output boundary
  • replace legacy LGTM annotations with current CodeQL suppression comments at five sinks already guarded by credential rejection or count-only contracts
  • add regression coverage for named credentials, bearer authorization, provider tokens, and ordinary security-count output

Security scope

Targets CodeQL alerts #438, #440, #444, #445, #446, and #447. The generic CLI sink is hardened; the other five alerts are guarded false positives documented at the exact sink.

Verification

  • 38 focused tests passed
  • Ruff passed on changed Python files
  • git diff --check passed
  • Full suite: 3326 passed, 8 skipped, 27 failed only because optional serve/semantic dependencies were not installed in the isolated worktree; exact-head CI is required before merge.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f4af8d0270

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/github_repo_auditor/cli_output.py Outdated
Comment thread src/github_repo_auditor/cli_output.py Outdated
@saagpatel
saagpatel merged commit 45ef0a8 into main Aug 21, 2026
4 checks passed
@saagpatel
saagpatel deleted the codex/resolve-codeql-sensitive-data-20260821 branch August 21, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant