Fix server subprocess command boundary - #229
Merged
Merged
Conversation
| def test_worker_passes_payload_to_cli_inside_child_process(self, monkeypatch) -> None: | ||
| from io import StringIO | ||
|
|
||
| import github_repo_auditor.cli as cli |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keep server-triggered audit process creation on a fixed OS command and move validated request values to a JSON stdin payload consumed by a dedicated worker. Explicitly escape the dynamic action-row index and remove the related CodeQL suppressions.
Why
The current remote security receipt reports one critical and eight high CodeQL alerts. This patch removes form-derived values from
subprocess.Popenarguments and makes the HTMX fragment boundary explicit so remote CodeQL can evaluate the real data flow.Review Of What Was Built
RunSessionnow launches onlypython -m github_repo_auditor.serve.worker.Cleanup Review
Removed two reflective-XSS CodeQL suppressions. Preserved the pre-existing untracked portfolio-truth lock and made no generated-output changes.
Verification Summary
72 passed, 2 skipped.git diff --check: passed.responsesdependency is absent; no package installation was performed.Shipped Summary
The feature branch contains commit
fcf10baand is ready for CI and CodeQL review. It is not merged or deployed.Next Phase
Wait for remote CI and CodeQL, inspect any surviving findings, then collect a newer authoritative GitHub security receipt and regenerate the source-matched PortfolioTruth/DecisionBrief outputs.
Remaining Roadmap
AIGCCore remediation remains out of scope; partial security-provider coverage and owner-bound BridgeDB actions remain separate lanes.