fix: resolve portfolio decision queue catalog entries#163
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8bed53666a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds explicit portfolio catalog contracts for
fable-os-divergenceandfable-site-rebuild, and repairs the canonicalSignal & Noisecontract so thesignal-noiseworkspace path resolves to that canonical entry.Why
The weekly portfolio review surfaced these as decision-needed because they had no declared operating path. The two Fable folders are campaign/control-room workspaces, not default active product surfaces.
Signal & Noiseis an active maintained product surface and should not sit in investigate-only limbo because the local checkout/repo slug differs from the canonical display name.Review Of What Was Built
fable-os-divergenceas an experimental infrastructure campaign workspace.fable-site-rebuildas an experimental infrastructure control room whose product target isportfolio-index.Signal & Noisecatalog entry with product metadata andaliases: [signal-noise].catalog_entry_for_repo()can match a workspace path/repo slug to the canonical catalog entry.Cleanup Review
This removes false queue pressure without changing product code or broad portfolio policy. No parked/archive docs refresh was added.
Verification Summary
python3.13 - <<'PY' ... yaml.safe_load(...)verified the catalog parses and the canonicalSignal & Noiseentry owns thesignal-noisealias.python3.13 -m src.cli report saagpatel --portfolio-truth --portfolio-truth-include-security --output-dir outputregenerated truth with Notion context loaded.python3.13 -m src.cli security-gate --output-dir output --max-age-hours 168 --jsonpassed: 135 scanned, 0 high, 0 critical, source age 0.01h.python3.13 -m pytest tests/test_portfolio_catalog.py tests/test_portfolio_security_gate.py tests/test_portfolio_truth.py -qpassed: 88 tests.Shipped Summary
Fresh local truth resolves the decision queue to zero and keeps default attention bounded to active product/infra only.
Next Phase
Merge this catalog repair, then rerun the next weekly portfolio review against the fresh truth snapshot. Main dependency: keep GHAS overlay generation in the weekly path so the security gate does not fall back to unknown.
Remaining Roadmap
Signal & Noisetracked as maintained product work through its canonical catalog entry, with normal product/release evidence when it changes.