Skip to content

ci: gate macOS build outside pull requests#115

Closed
saagpatel wants to merge 0 commit into
masterfrom
codex/ci/actions-cost-hygiene
Closed

ci: gate macOS build outside pull requests#115
saagpatel wants to merge 0 commit into
masterfrom
codex/ci/actions-cost-hygiene

Conversation

@saagpatel
Copy link
Copy Markdown
Owner

What

  • Add manual dispatch for the main CI workflow.
  • Skip the full macOS build job during pull_request runs.

Why

  • GitHub usage data showed AssistSupport has expensive macOS build minutes on PRs.

How

  • Keep the existing Linux and macOS test jobs for PR validation.
  • Run the full macOS build on push or manual dispatch instead of every PR.

Testing

  • Parsed changed workflow YAML successfully.
  • Not run: full product test suite, because this PR only changes workflow trigger behavior.

Performance Impact

  • Expected to reduce macOS Actions minutes on pull requests.

Risk / Notes

  • Full macOS build still runs outside PR events and can be manually dispatched.
  • Existing concurrency cancellation remains in place.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 304fafb47d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml Outdated

build:
name: Build (macOS)
if: github.event_name != 'pull_request'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the required macOS build from passing when skipped

For pull_request runs targeting master, this skips the Build (macOS) job even though the repo's branch-protection notes list Build (macOS) as a required check (docs/plans/current-remediation-plan.md). GitHub documents that a job skipped by a conditional reports Success, so PRs can satisfy branch protection without ever running pnpm tauri build; a PR that breaks the packaged macOS app would only be caught after merge on the push workflow.

Useful? React with 👍 / 👎.

@saagpatel saagpatel closed this May 17, 2026
@saagpatel saagpatel force-pushed the codex/ci/actions-cost-hygiene branch from 304fafb to 9f5580e Compare May 17, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant