ci: gate macOS build outside pull requests#115
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 304fafb47d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| build: | ||
| name: Build (macOS) | ||
| if: github.event_name != 'pull_request' |
There was a problem hiding this comment.
Keep the required macOS build from passing when skipped
For pull_request runs targeting master, this skips the Build (macOS) job even though the repo's branch-protection notes list Build (macOS) as a required check (docs/plans/current-remediation-plan.md). GitHub documents that a job skipped by a conditional reports Success, so PRs can satisfy branch protection without ever running pnpm tauri build; a PR that breaks the packaged macOS app would only be caught after merge on the push workflow.
Useful? React with 👍 / 👎.
304fafb to
9f5580e
Compare
What
Why
How
Testing
Performance Impact
Risk / Notes