Fixed Create mechanical rollers not filling correctly by bypassing block breaking distance check#1393
Open
adityapatn wants to merge 1 commit into
Open
Fixed Create mechanical rollers not filling correctly by bypassing block breaking distance check#1393adityapatn wants to merge 1 commit into
adityapatn wants to merge 1 commit into
Conversation
|
|
adityapatn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create mechanical rollers' "Sloped Fill" and "Straight Fill" modes interact with blocks much further away than other actors, and so should be excluded from Sable's distance check on whether to cancel the interaction in testBreakingPosDist in BlockBreakingMovementBehaviourMixin.java.
Error: Create Mechanical Rollers on Create trains do not fill below the first layer when Create and Sable are installed (Latest versions for Neoforge 1.21.1).
Fix: Add check for whether the MovementBehaviour is a RollerMovementBehaviour in the distance check in testBreakingPosDist.