Fix crash caused by removing rapier rigidbody before chunk unload finished#1093
Open
WaterOtter86 wants to merge 4 commits into
Open
Fix crash caused by removing rapier rigidbody before chunk unload finished#1093WaterOtter86 wants to merge 4 commits into
WaterOtter86 wants to merge 4 commits into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sable was removing the Rapier rigid body before Minecraft finished unloading the sublevel chunk. If a block entity touched/updated or did anythin with blocks during its chunk unload callback, Sable’s blockchange hook tried to update mass/physics and somewhy teleport? data for a body that no longer existed in Rapier, crashing the server thread. Sorry for lib.rs touch, was testing stuff.