Skip to content

fix(sona): expose find_patterns on EphemeralAgent + fix get_patterns returning empty #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sona): expose find_patterns on EphemeralAgent + fix get_patterns returning empty #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/sona/src/training/federated.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,12 @@ impl EphemeralAgent {

/// Get learned patterns from agent
pub fn get_patterns(&self) -> Vec<LearnedPattern> {
self.engine.find_patterns(&[], 0)
self.engine.get_all_patterns()
}

/// Find top-k patterns most similar to a query embedding
pub fn find_patterns(&self, query: &[f32], k: usize) -> Vec<LearnedPattern> {
self.engine.find_patterns(query, k)
}

/// Export agent state for federation
Expand Down
11 changes: 11 additions & 0 deletions crates/sona/src/wasm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,17 @@ impl WasmEphemeralAgent {
let patterns = self.inner.get_patterns();
serde_wasm_bindgen::to_value(&patterns).unwrap_or(JsValue::NULL)
}

/// Find top-k patterns most similar to a query embedding
///
/// # Arguments
/// * `query_embedding` - Query vector as Float32Array
/// * `k` - Number of patterns to return
#[wasm_bindgen(js_name = findPatterns)]
pub fn find_patterns(&self, query_embedding: Vec<f32>, k: usize) -> JsValue {
let patterns = self.inner.find_patterns(&query_embedding, k);
serde_wasm_bindgen::to_value(&patterns).unwrap_or(JsValue::NULL)
}
}

/// WASM-compatible Federated Coordinator
Expand Down
Loading